TL/SHARP: add support for allgather #1081
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bureddy
approved these changes
Feb 25, 2025
samnordmann
approved these changes
Feb 26, 2025
| dst_data_size = ucc_dt_size(dt) * count; | ||
|
|
||
| if (!UCC_IS_INPLACE(*args)) { | ||
| ucc_tl_sharp_mem_register(TASK_CTX(task), team, args->src.info.buffer, |
| break; | ||
| case UCC_COLL_TYPE_ALLGATHER: | ||
| if (!UCC_IS_INPLACE(TASK_ARGS(task))) { | ||
| ucc_tl_sharp_mem_deregister(TASK_TEAM(task), |
There was a problem hiding this comment.
we should check status, even though IIUC ucc_tl_sharp_mem_deregister cannot return any error -- in this case we might want to change the return type to void
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Add support SHARP allgather. Fix regsitration in reduce scatter