Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TL/UCP: add local copy option #1077

Merged

Conversation

Sergei-Lebedev
Copy link
Contributor

What

Add option to use ec copy, mc copy or ucp copy for local copy in TL UCP
See PR #1021 for more details

@Sergei-Lebedev Sergei-Lebedev force-pushed the topic/tl_ucp_add_local_copy_switch branch 2 times, most recently from f6c6c20 to cc999a4 Compare February 24, 2025 11:53
@artemry-nv
Copy link
Collaborator

bot:retest

Copy link
Collaborator

@janjust janjust left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks really clean to me, thanks

@janjust
Copy link
Collaborator

janjust commented Feb 25, 2025

bot:retest

1 similar comment
@janjust
Copy link
Collaborator

janjust commented Feb 25, 2025

bot:retest

Copy link
Collaborator

@samnordmann samnordmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Sergei-Lebedev Sergei-Lebedev force-pushed the topic/tl_ucp_add_local_copy_switch branch from f8730da to 59f06c8 Compare February 26, 2025 13:02
@MamziB
Copy link
Collaborator

MamziB commented Feb 26, 2025

great patch, thanks Sergey

@artemry-nv
Copy link
Collaborator

bot:retest

@artemry-nv
Copy link
Collaborator

Fixed the CI lab issue (IB ports were in PORT_INIT state).

@lappazos
Copy link
Contributor

bot:retest

@janjust janjust force-pushed the topic/tl_ucp_add_local_copy_switch branch from 59f06c8 to 2fee085 Compare February 28, 2025 23:54
@janjust janjust enabled auto-merge (squash) February 28, 2025 23:55
@janjust
Copy link
Collaborator

janjust commented Feb 28, 2025

@samnordmann I resolved one of your comments out of urgency, I saw you commit change, and if necessary, we can open a quick PR to address it if needed.

@janjust janjust merged commit d6e7ec2 into openucx:master Mar 1, 2025
8 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants