add local eslint rule rule for banning concat and new performance test #690
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This adds a test for #683 as well as a new local eslint rule for banning
concat()
. In favour ofpush(...)
.It also refactors all instances of
concat()
throughout the code base, so we should wait for several other outstanding PRs before merging this, in order to avoid a mass of conflicts. This PR is also blocked by #683 because it depends on it.Motivation and Context
#513 and #683 show a clear performance improvement especially for larger/more complex fonts.
How Has This Been Tested?
Made sure the tests are all still passing.
Types of changes
Checklist:
npm run test
and all tests passed green (including code styling checks).