Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix keys retrieval in objectsEqual function #665

Merged
merged 5 commits into from
Mar 22, 2024
Merged

Fix keys retrieval in objectsEqual function #665

merged 5 commits into from
Mar 22, 2024

Conversation

ralfstx
Copy link
Contributor

@ralfstx ralfstx commented Dec 29, 2023 •
edited
Loading

Description

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I did npm run test and all tests passed green (including code styling checks).
  • I have added tests to cover my changes.
  • My change requires a change to the documentation.
  • I have updated the README accordingly.
  • I have read the CONTRIBUTING document.

@Connum
Copy link
Contributor

Connum commented Dec 29, 2023

Can you please add a test for this that would have caught the issue?

@ralfstx
Copy link
Contributor Author

ralfstx commented Dec 29, 2023

Can you please add a test for this that would have caught the issue?

Okay, here you go. Feel free to adjust to your conventions.

@Connum Connum self-requested a review March 22, 2024 17:12
Connum
Connum approved these changes Mar 22, 2024
View reviewed changes
Copy link
Contributor

@Connum Connum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The tests were missing a case that actually failed before the fix and passes now. I added one.
🚀

@Connum Connum merged commit 6408975 into opentypejs:master Mar 22, 2024
1 check passed
@Connum Connum added the dev Changes revolving merely around dev-related code like testing, build process, etc. label Mar 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Connum Connum Connum approved these changes

Assignees
No one assigned
Labels
dev Changes revolving merely around dev-related code like testing, build process, etc.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ralfstx @Connum