Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

correct 2x2 glyf transformation (fix #432) #652

Merged
merged 2 commits into from
Nov 30, 2023
Merged

Conversation

Connum
Copy link
Contributor

@Connum Connum commented Nov 26, 2023

Description

swapped 2x2 glyf transformation values

Motivation and Context

fix #432

How Has This Been Tested?

checked "+" glyph in Changar font before and after, added test case

Screenshots (if appropriate):

before:
image

after:
image

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I did npm run test and all tests passed green (including code styling checks).
  • I have added tests to cover my changes.
  • My change requires a change to the documentation.
  • I have updated the README accordingly.
  • I have read the CONTRIBUTING document.

@Connum Connum added the bug label Nov 26, 2023
@Connum Connum added this to the Release 2.0.0 milestone Nov 26, 2023
@Connum Connum requested review from ILOVEPIE and yne November 26, 2023 23:33
@Connum Connum changed the title correct 2x2 glyf transformation (fix #135) correct 2x2 glyf transformation (fix #432) Nov 26, 2023
Copy link
Contributor

@ILOVEPIE ILOVEPIE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@Connum Connum merged commit 04fa833 into opentypejs:master Nov 30, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Composite glyph 2x2 transformation has wrong order.
2 participants