Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add missing import file extensions, add @TODO comments for refactoring #582

Merged
merged 1 commit into from
Mar 3, 2023

Conversation

Connum
Copy link
Contributor

@Connum Connum commented Mar 3, 2023

Description

adds missing import file extensions

Motivation and Context

While reviewing #535, I noticed that some imports were still missing the file extension that we need now after changing the build system and allowing the library to work in module form in browser context. While I was at it, I also added TODO comments for something we need to address after #564 is merged.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I did npm run test and all tests passed green (including code styling checks).
  • I have added tests to cover my changes.
  • My change requires a change to the documentation.
  • I have updated the README accordingly.
  • I have read the CONTRIBUTING document.

@Connum Connum requested review from ILOVEPIE and yne March 3, 2023 16:06
@yne yne merged commit c5c2c06 into opentypejs:master Mar 3, 2023
@Connum Connum deleted the fix-imports-add-todos branch March 6, 2023 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants