Skip to content

better handle blank itineraries #1444

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 29, 2025
Merged

better handle blank itineraries #1444

merged 1 commit into from
Jul 29, 2025
+10 −1

Conversation

miles-grant-ibigroup
Copy link
Collaborator

@miles-grant-ibigroup miles-grant-ibigroup commented Jul 25, 2025 •
edited
Loading

An undefined itinerary previously crashed the UI. Now we let our error handler render

daniel-heppner-ibigroup
daniel-heppner-ibigroup reviewed Jul 25, 2025
View reviewed changes
Copy link
Contributor

@daniel-heppner-ibigroup daniel-heppner-ibigroup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd like to know when this is happening before I approve. Are you getting nulls back in the array or something? Can you show me where this problem is showing up?

@miles-grant-ibigroup
Copy link
Collaborator Author

miles-grant-ibigroup commented Jul 28, 2025 •
edited
Loading

I'd like to know when this is happening before I approve. Are you getting nulls back in the array or something? Can you show me where this problem is showing up?

It's happening in cases where OTP is crashing. It returns nulls in the array

@miles-grant-ibigroup miles-grant-ibigroup removed their assignment Jul 28, 2025
daniel-heppner-ibigroup
daniel-heppner-ibigroup approved these changes Jul 28, 2025
View reviewed changes
Copy link
Contributor

@daniel-heppner-ibigroup daniel-heppner-ibigroup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Glad that this is being resolved in OTP. Can you add a comment explaining what we talked about, though? I could see myself removing this at some point wondering why it exists since it technically shouldn't be necessary.

@miles-grant-ibigroup miles-grant-ibigroup merged commit 3e9a55e into dev Jul 29, 2025
9 checks passed
@miles-grant-ibigroup miles-grant-ibigroup deleted the catch-blank-itin-better branch July 29, 2025 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alec-georgoff alec-georgoff alec-georgoff approved these changes

@daniel-heppner-ibigroup daniel-heppner-ibigroup daniel-heppner-ibigroup approved these changes

Assignees

@miles-grant-ibigroup miles-grant-ibigroup

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@miles-grant-ibigroup @alec-georgoff @daniel-heppner-ibigroup