Skip to content

Conversation

miles-grant-ibigroup
Copy link
Collaborator

Description:
Makes a few cleanup changes to the schedule view to accommodate some other changes. Fixes icons, paddings, and icon placements
Screenshot 2025-07-02 at 11 57 19 AM

@miles-grant-ibigroup
Copy link
Collaborator Author

Unsure about percy tests... I think they look good but I'll wait to get a second opinion

Copy link
Contributor

@amy-corson-ibigroup amy-corson-ibigroup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few tweaks!

Copy link
Contributor

@amy-corson-ibigroup amy-corson-ibigroup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looking better! Just clarifying some of my previous notes. The biggest thing is just that inconsistency in spacing between stations and stops

@amy-corson-ibigroup
Copy link
Contributor

Schedule view is looking good but something about the nearby layout broke :(
image

Copy link
Contributor

@amy-corson-ibigroup amy-corson-ibigroup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good thanks for the chnages!

@alec-georgoff
Copy link
Collaborator

My view looks a little different on Safari:

image

compared to your example:

image

Are these differences enough to worry about?

@miles-grant-ibigroup
Copy link
Collaborator Author

My view looks a little different on Safari:
image

compared to your example:
image

Are these differences enough to worry about?

These are the result of @amy-corson-ibigroup's comments!

@miles-grant-ibigroup miles-grant-ibigroup merged commit dc181d6 into dev Aug 4, 2025
9 checks passed
@miles-grant-ibigroup miles-grant-ibigroup deleted the scheudle-viewer-cleanup branch August 4, 2025 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants