Indicate to AT that element is currently selected #1408
Merged
+21
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daniel-heppner-ibigroup
assigned
amy-corson-ibigroup and unassigned
daniel-heppner-ibigroup
miles-grant-ibigroup
requested changes
Jun 6, 2025
lib/components/viewers/route-row.tsx
Outdated
Comment on lines
211
to
213
| ( | ||
| <FormattedMessage id="components.RouteViewer.currentlySelected" /> | ||
| ) |
There was a problem hiding this comment.
We've been told in the past that brackets have to be localized.
amy-corson-ibigroup
changed the title
|
I updated this PR to also add this string to the locale selector and the sorting dropdown! @miles-grant-ibigroup @daniel-heppner-ibigroup |
miles-grant-ibigroup
requested changes
Jun 9, 2025
| @@ -192,6 +192,11 @@ export default function NarrativeItinerariesHeader({ | |||
| role="option" | |||
| > | |||
| {sortOption.text} | |||
| {sortText === sortOption.text && ( | |||
| <InvisibleA11yLabel> | |||
| <FormattedMessage id="coommon.currentlySelected" /> | |||
i18n/fr.yml
Outdated
| @@ -76,6 +76,7 @@ actions: | |||
| réessayez. | |||
| common: | |||
| coordinates: "{lat}; {lon}" | |||
| currentlySelected: (actuellement sélectionné) | |||
There was a problem hiding this comment.
Do we need a hardcoded space here to prevent the words from squishing together?
There was a problem hiding this comment.
might as well!
There was a problem hiding this comment.
you 🤝 codespell
miles-grant-ibigroup
approved these changes
Jun 10, 2025
| @@ -192,6 +192,11 @@ export default function NarrativeItinerariesHeader({ | |||
| role="option" | |||
| > | |||
| {sortOption.text} | |||
| {sortText === sortOption.text && ( | |||
| <InvisibleA11yLabel> | |||
| <FormattedMessage id="commmon.currentlySelected" /> | |||
There was a problem hiding this comment.
cant spell this to save my life huh
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Adds a "(currently selected)" string to active links so AT users know which route is active.
Also adds it to locale selector and sort option since
aria-selectedis being a little inconsistent on those components.PR Checklist: