Skip to content

Import new DT selector #1395

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 18 commits into from
Jun 18, 2025
Merged

Import new DT selector #1395

merged 18 commits into from
Jun 18, 2025

Conversation

amy-corson-ibigroup
Copy link
Contributor

@amy-corson-ibigroup amy-corson-ibigroup commented May 15, 2025

Description:

  • Import new date/time selector from OTP-UI
  • Update trip plan form to current date/time if plan trip button is pressed when the fields are blank
  • remove old styling
  • If set to "depart" or "arrive" sets focus directly to the d/t inputs

PR Checklist:

  • Does the code follow accessibility standards (WCAG 2.1 AA Compliant)?
  • Are all languages supported (Internationalization/Localization)?
  • Are appropriate Typescript types implemented?
Web Mobile
image image

@amy-corson-ibigroup amy-corson-ibigroup added the BLOCKED Blocked (waiting on another PR to be merged) label May 15, 2025
@amy-corson-ibigroup amy-corson-ibigroup changed the title account for new DT selector Import new DT selector Jun 3, 2025
@amy-corson-ibigroup amy-corson-ibigroup removed the BLOCKED Blocked (waiting on another PR to be merged) label Jun 4, 2025
@binh-dam-ibigroup
Copy link
Collaborator

binh-dam-ibigroup commented Jun 9, 2025

@amy-corson-ibigroup Is it me, or is the time (and date too maybe) not being propagated, even after clicking Plan Trip again? (see screenshot below)

image

Copy link
Collaborator

@binh-dam-ibigroup binh-dam-ibigroup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you address the double error message when clicking Plan Trip with empty origin/destination fields, please? See also the other nits.

@amy-corson-ibigroup
Copy link
Contributor Author

amy-corson-ibigroup commented Jun 10, 2025

Is it me, or is the time (and date too maybe) not being propagated, even after clicking Plan Trip again? (see screenshot below)

Hmm can you elaborate on why this is wrong? Seems like if you're trying to arrive by 3:02PM, these are all appropriate departure times

@binh-dam-ibigroup
Copy link
Collaborator

Is it me, or is the time (and date too maybe) not being propagated, even after clicking Plan Trip again? (see screenshot below)

Hmm can you elaborate on why this is wrong? Seems like if you're trying to arrive by 3:02PM, these are all appropriate departure times

This might have been a glitch, please disregard the original comment.

Copy link
Collaborator

@binh-dam-ibigroup binh-dam-ibigroup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, good to go with me after you update the snapshots.

Copy link
Contributor

@josh-willis-arcadis josh-willis-arcadis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks super slick! Percy build needs to be approved, but looks good to me!

@amy-corson-ibigroup
Copy link
Contributor Author

Thanks everyone!

@amy-corson-ibigroup amy-corson-ibigroup merged commit f196d98 into dev Jun 18, 2025
9 checks passed
@amy-corson-ibigroup amy-corson-ibigroup deleted the dt-selector-update branch June 18, 2025 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants