-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Only run "Debug Client" workflow on dev-2.x
branch
#6402
base: dev-2.x
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev-2.x #6402 +/- ##
=============================================
+ Coverage 69.73% 69.84% +0.10%
- Complexity 18023 18123 +100
=============================================
Files 2057 2069 +12
Lines 76978 77268 +290
Branches 7845 7855 +10
=============================================
+ Hits 53678 53964 +286
+ Misses 20550 20547 -3
- Partials 2750 2757 +7 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The title is slightly misleading as this only prevents the workflow being run in a fork if the fork doesn't use the same branch naming convention as upstream. Unfortunately I don't think there is a way to define on which repositories the action should run on (apart from the repository owner check that we already do here but with that solution the workflow still starts but is then aborted).
In general I would recommend using a different name to the master/development branch in a fork - to avoid misstakes. For example will git automatically set the upstream repository matching the branch name in some cases. This could lead to pushing changes to the wrong repository. We reasently switch over pipeline from a fork of HSLs repo to using the main opentripplanner repo and changing the entur release branch from |
dev-2.x
branch
Summary
This action is run today in entur downstream fork when someone changes a file under
/client/**
. The action is aborted, but it clutter up the list of run actions. I am not an expert on workflows, but I chaned it slightly so the trigger now filter on both path and branch for pushes. This also make the script a bit cleaner, since the branch filter does not need to be repeated in the run section.Issue
🟥 There is no issue for this.
Unit tests
🟥 This is CI config change, we do not have tests for this.
Documentation
🟥 I have not changed/added doc.
Changelog
🟥 Not relevant
Bumping the serialization version id
🟥 There is no changes to the OTP code.