Use SIRI-ET and GTFS-RT TripUpdates at the same time #6363
+328
−494
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leonardehrenfried
added
Technical Debt
Real-Time Update
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev-2.x #6363 +/- ##
=============================================
+ Coverage 69.77% 69.80% +0.02%
- Complexity 18053 18079 +26
=============================================
Files 2060 2064 +4
Lines 77122 77154 +32
Branches 7856 7846 -10
=============================================
+ Hits 53814 53858 +44
+ Misses 20556 20543 -13
- Partials 2752 2753 +1 ☔ View full report in Codecov by Sentry. |
leonardehrenfried
force-pushed
the
siri-gtfs
branch
from
f80a8a6 to
5f8eb10
Compare
leonardehrenfried
changed the title
vpaturet
requested changes
Jan 27, 2025
application/src/main/java/org/opentripplanner/transit/service/DefaultTransitService.java
Outdated
Show resolved
Hide resolved
application/src/main/java/org/opentripplanner/updater/spi/TimetableSnapshotFlush.java
Show resolved
Hide resolved
vpaturet
reviewed
Jan 29, 2025
application/src/main/java/org/opentripplanner/transit/service/DefaultTransitService.java
Outdated
Show resolved
Hide resolved
vpaturet
approved these changes
Jan 29, 2025
|
So removing fields doesn't count as breaking backwards-compatibility? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Previously it was not possible to run SIRI-ET and GTFS-RT TripUpdates in the same instance. This PR changes it by cleaning up the relationships of the various real-time components.
A class diagram to show the new relationships is available in the issue #6348.
Issue
Closes #6348
Unit tests
Some unit tests updated.
Documentation
The new class diagram is available in this PR in
doc/dev/diagrams/TimetableSnapshotManager.svg.Bumping the serialization version id
While no actual entities have changed, but the
TimetableRepositoryhas which is serialized into the graph. Therefore we need to bump it.cc @fahrplaner