Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore/vonage video shim #354

Merged
merged 6 commits into from
Feb 26, 2025
Merged

Chore/vonage video shim #354

merged 6 commits into from
Feb 26, 2025

Conversation

SecondeJK
Copy link
Contributor

@SecondeJK SecondeJK commented Jan 15, 2025

This PR provides a shim layer to divert traffic to the Vonage Video API with a JWT created from the application id and private key from the Vonage Video Dashboard.

Description

You can now add these options in, and the SDK will take care of the rest.

use OpenTok\OpenTok;
use MyCompany\CustomOpenTokClient;

$options = [
    'application_id' => 'your_application_id',
    'private_key_path' => './path-to-your.key'
]

$opentok = new OpenTok($apiKey, $apiSecret, $options);

Motivation and Context

Backwards compatibility shim while developers shift to the new platform.

How Has This Been Tested?

Test added to cover the scenario

Example Output or Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@dragonmantank dragonmantank merged commit 4a433ae into main Feb 26, 2025
8 checks passed
@dragonmantank dragonmantank deleted the chore/vonage-video-shim branch February 26, 2025 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants