add one additional validation for the provider keys #1894
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yottta
force-pushed
the
validate-key-against-release
branch
from
59d06ae to
7a6c701
Compare
Signed-off-by: yottta <[email protected]>
yottta
force-pushed
the
validate-key-against-release
branch
from
7a6c701 to
dacbef3
Compare
Yantrio
reviewed
Mar 21, 2025
Yantrio
approved these changes
Mar 21, 2025
Signed-off-by: yottta <[email protected]>
yottta
force-pushed
the
validate-key-against-release
branch
from
7fbee49 to
e2a7cb2
Compare
ollevche
approved these changes
Mar 24, 2025
…provider name Signed-off-by: yottta <[email protected]>
Signed-off-by: yottta <[email protected]>
yottta
force-pushed
the
validate-key-against-release
branch
from
6c518e3 to
7377054
Compare
Signed-off-by: Andrei Ciobanu <[email protected]>
Signed-off-by: Andrei Ciobanu <[email protected]>
yottta
force-pushed
the
validate-key-against-release
branch
from
4d40378 to
dc2338c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolved #356
These are the validations that I personally run every time a new provider key is submitted.
I suggest adding these in the script that validates the submitted keys. This way, we also tackle this part of the PROCEDURES.md.
As also discussed in #356, we could also use
tofu initfor doing so but for the moment that is overkill. In case the current approach does not suffice, we could reiterate later.