[mdns-publisher] move link-local address filtering to DiscoveryProxy #2710
+40
−20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abtink
force-pushed
the
mdns/link-local-addr-filter
branch
from
f7b8bff to
66e406f
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2710 +/- ##
===========================================
- Coverage 55.77% 43.47% -12.31%
===========================================
Files 87 108 +21
Lines 6890 13354 +6464
Branches 0 953 +953
===========================================
+ Hits 3843 5805 +1962
- Misses 3047 7242 +4195
- Partials 0 307 +307 ☔ View full report in Codecov by Sentry. |
abtink
force-pushed
the
mdns/link-local-addr-filter
branch
from
66e406f to
ed59fa9
Compare
abtink
force-pushed
the
mdns/link-local-addr-filter
branch
from
ed59fa9 to
152b640
Compare
This commit modifies the `Publisher` to stop filtering link-local addresses during service or host resolution. Instead, the `DiscoveryProxy` now handles link-local address filtering. This change allows the `Publisher` to properly resolve TREL peers, which require link-local addresses.
abtink
force-pushed
the
mdns/link-local-addr-filter
branch
from
152b640 to
87d2939
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit modifies the
Publisherto stop filtering link-local addresses during service or host resolution. Instead, theDiscoveryProxynow handles link-local address filtering. This change allows thePublisherto properly resolve TREL peers, which require link-local addresses.