Commit-Reveal Weight Inheritance

pallets/admin-utils/src/lib.rs

@@ -107,6 +107,8 @@ pub mod pallet {
         BondsMovingAverageMaxReached,
         /// Only root can set negative sigmoid steepness values
         NegativeSigmoidSteepness,
+        /// Reveal Peroid is not within the valid range.
+        RevealPeriodOutOfBounds,
     }
     /// Enum for specifying the type of precompile operation.
     #[derive(Encode, Decode, TypeInfo, Clone, PartialEq, Eq, Debug, Copy)]
@@ -1364,6 +1366,12 @@ pub mod pallet {
                 Error::<T>::SubnetDoesNotExist
             );
 
+            const MAX_COMMIT_REVEAL_PEROIDS: u64 = 100;
+            ensure!(
+                interval <= MAX_COMMIT_REVEAL_PEROIDS,
+                Error::<T>::RevealPeriodOutOfBounds
+            );
+
             pallet_subtensor::Pallet::<T>::set_reveal_period(netuid, interval);
             log::debug!(
                 "SetWeightCommitInterval( netuid: {:?}, interval: {:?} ) ",

pallets/admin-utils/src/tests/mod.rs

@@ -1456,6 +1456,16 @@ fn sudo_set_commit_reveal_weights_interval() {
         let netuid = NetUid::from(1);
         add_network(netuid, 10);
 
+        let too_high = 101;
+        assert_err!(
+            AdminUtils::sudo_set_commit_reveal_weights_interval(
+                <<Test as Config>::RuntimeOrigin>::root(),
+                netuid,
+                too_high
+            ),
+            Error::<Test>::RevealPeriodOutOfBounds
+        );
+
         let to_be_set = 55;
         let init_value = SubtensorModule::get_reveal_period(netuid);
 

pallets/subtensor/src/epoch/run_epoch.rs

@@ -577,6 +577,32 @@ impl<T: Config> Pallet<T> {
         );
         log::trace!("Weights (permit+diag+outdate): {:?}", &weights);
 
+        if Self::get_commit_reveal_weights_enabled(netuid) {
+            // Precompute safe blocks for all UIDs
+            let safe_blocks: Vec<u64> = block_at_registration
+                .iter()
+                .map(|reg_block| {
+                    let reg_epoch = Self::get_epoch_index(netuid, *reg_block);
+                    let safe_epoch =
+                        reg_epoch.saturating_add(Self::get_reveal_period(netuid).saturating_mul(2));
+
+                    Self::get_first_block_of_epoch(netuid, safe_epoch)
+                })
+                .collect();
+
+            // Mask out weights to recently registered UIDs
+            weights = vec_mask_sparse_matrix(
+                &weights,
+                &last_update,
+                &safe_blocks,
+                &|updated, safe_block| updated < safe_block,
+            );
+
+            log::trace!(
+                "Masking weights to miners inside reveal window (recent registrations masked)"
+            );
+        }
+
         // Normalize remaining weights.
         inplace_row_normalize_sparse(&mut weights);
         log::trace!("Weights (mask+norm): {:?}", &weights);

pallets/subtensor/src/subnets/weights.rs

@@ -1095,4 +1095,13 @@ impl<T: Config> Pallet<T> {
     pub fn get_reveal_period(netuid: NetUid) -> u64 {
         RevealPeriodEpochs::<T>::get(netuid)
     }
+
+    pub fn get_first_block_of_epoch(netuid: NetUid, epoch: u64) -> u64 {
+        let tempo: u64 = Self::get_tempo(netuid) as u64;
+        let tempo_plus_one: u64 = tempo.saturating_add(1);
+        let netuid_plus_one: u64 = (u16::from(netuid) as u64).saturating_add(1);
+        epoch
+            .saturating_mul(tempo_plus_one)
+            .saturating_sub(netuid_plus_one)
+    }
 }