Skip to content

Refactor rate limits #1713

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 10 commits into from
Closed

Conversation

shamil-gadelshin
Copy link
Collaborator

Description

This PR migrates obsolete rate limits into the existing map LastRateLimitedBlock:

  • TxDelegateTakeRateLimit
  • TxChildkeyTakeRateLimit
  • TxRateLimit
  • NetworkRateLimit
  • ServingRateLimit
  • WeightsSetRateLimit

Related Issue(s)

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Other (please describe):

Breaking Change

This PR changes storage maps semantics - default values are zero when requested using the storage RPC. The runtime getters return the previous default values.

Checklist

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have run cargo fmt and cargo clippy to ensure my code is formatted and linted correctly
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@shamil-gadelshin shamil-gadelshin requested a review from gztensor June 3, 2025 11:14
@github-actions github-actions bot added the run-bittensor-e2e-tests Runs Bittensor SDK and BTCLI tests label Jun 3, 2025
@shamil-gadelshin shamil-gadelshin added the skip-cargo-audit This PR fails cargo audit but needs to be merged anyway label Jun 3, 2025
@shamil-gadelshin
Copy link
Collaborator Author

There will be a second part for this task (after a discussion with @gztensor) for dealing with LastTxBlock, LastTxBlockChildKeyTake, LastTxBlockDelegateTake, etc.

@shamil-gadelshin shamil-gadelshin marked this pull request as draft June 4, 2025 09:20
@shamil-gadelshin
Copy link
Collaborator Author

Superseded by #1721

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
run-bittensor-e2e-tests Runs Bittensor SDK and BTCLI tests skip-cargo-audit This PR fails cargo audit but needs to be merged anyway
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants