Skip to content

dTao-Compatible Subnet Deregistration #1685

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 40 commits into
base: devnet-ready
Choose a base branch
from

Conversation

JohnReedV
Copy link
Contributor

Description

dTao-Compatible Subnet Deregistration

Related Issue(s)

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Other (please describe):

@mcjkula
Copy link

mcjkula commented May 27, 2025

Currently the immunity period of the subnet's neurons is being called instead of the network immunity period, which you should be able to get with Self::get_network_immunity_period(); (I think), as well you don't need to cast it as u64, because the method then already returns u64. @JohnReedV

@JohnReedV JohnReedV changed the title dTao-Compatible Subnet Deregistration dTao-Compatible Subnet Deregistration WIP Jun 2, 2025
@JohnReedV JohnReedV added the skip-cargo-audit This PR fails cargo audit but needs to be merged anyway label Jun 9, 2025
@JohnReedV JohnReedV changed the title dTao-Compatible Subnet Deregistration WIP dTao-Compatible Subnet Deregistration Jun 9, 2025
@JohnReedV JohnReedV marked this pull request as ready for review June 9, 2025 20:00
@JohnReedV JohnReedV added run-bittensor-e2e-tests Runs Bittensor SDK and BTCLI tests labels Jun 18, 2025
#[pallet::type_value]
/// Default value for subnet limit.
pub fn DefaultSubnetLimit<T: Config>() -> u16 {
256

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

256 or 128?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
run-bittensor-e2e-tests Runs Bittensor SDK and BTCLI tests skip-cargo-audit This PR fails cargo audit but needs to be merged anyway
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants