Skip to content

Add non-fast-blocks e2e tests each Saturday #2860

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 41 commits into from
May 12, 2025

Conversation

basfroman
Copy link
Contributor

@basfroman basfroman commented May 3, 2025

Changes:

  • runs e2e tests on fast-blocks every night
  • runs e2e tests on non-fast-blocks every Saturday

All cron non-fast-tests passed https://github.com/opentensor/bittensor/actions/runs/14950943125?pr=2860

Comment on lines +1974 to +1977
def is_fast_blocks(self):
"""Returns True if the node is running with fast blocks. False if not."""
return self.query_constant("SubtensorModule", "DurationOfStartCall").value == 10

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm glad you didn't make these properties.

]

cmds += params.split() if params else []

print("Entire run command: ", cmds)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this necessary or left over from debugging?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

useful for checking while running tests

@basfroman basfroman merged commit 3835390 into staging May 12, 2025
126 checks passed
@basfroman basfroman deleted the feat/roman/add-non-fast-block-tests-each-saturday branch May 12, 2025 16:02
@ibraheem-abe ibraheem-abe mentioned this pull request May 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants