Only use Runtime objects in AsyncSubstrateInterface #141
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…istently using the runtime object or the self.runtime
basfroman
reviewed
Jun 25, 2025
thewhaleking
added
run-bittensor-sdk-tests
thewhaleking
changed the title
thewhaleking
changed the title
|
Still ironing out some issues. Don't review yet. Need it in "ready for review" for tests though. |
thewhaleking
changed the title
basfroman
approved these changes
Jun 27, 2025
Comment on lines
+1364
to
+1366
| module_name, | ||
| error_name, | ||
| block_hash=None, |
Comment on lines
+3098
to
+3101
| self, | ||
| module_name, | ||
| constant_name, | ||
| block_hash=None, |
Comment on lines
+646
to
+649
| self, | ||
| storage_item: ScaleType, | ||
| module, | ||
| spec_version_id, |
Comment on lines
+119
to
+127
| @pytest.mark.asyncio | ||
| async def test_legacy_decoding(): | ||
| # roughly 4000 blocks before metadata v15 was added | ||
| pre_metadata_v15_block = 3_010_611 | ||
|
|
||
| async with AsyncSubstrateInterface(ARCHIVE_ENTRYPOINT) as substrate: | ||
| block_hash = await substrate.get_block_hash(pre_metadata_v15_block) | ||
| events = await substrate.get_events(block_hash) | ||
| assert isinstance(events, list) |
There was a problem hiding this comment.
I'd avoid do real calls within kinda unit tests bc it's already e2e testing actually
The same for another tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AsyncSubstrateInterface has a problem. As it was ported from the synchronous version of SubstrateInterface, the
self.runtimewould always be valid in a synchronous context, but in an async context, where you may be concurrently querying multiple blocks with differing runtimes, there are potential issues. As the runtime version does not change often, this is unlikely to occur, but it certainly can, and when it does it's incredibly difficult to locate the source of the problems.This PR addresses those issues by ensuring that we always create Runtime objects, and pass those around, rather than relying on the
self.runtimeto be correct at any given time.The end-users will be completely unaffected negatively, as they do not need to specify Runtimes, but may see some speed improvements in various chained calls that call
AsyncSubstrateInterface.init_runtime, in addition to better assurance of correctness.The only issue I see may come from subscription handlers. Though I will investigate this further before finishing the PR and setting it R4R.UnaffectedAdded benefit: this made it easy to add in legacy Metadata V14 support, which will resolve #112