-
Notifications
You must be signed in to change notification settings - Fork 24
fix(authz): handle individual resource edge cases in decisions [backport to release/service/v0.11] #2846
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
jakedoublev
merged 1 commit into
release/service/v0.11
from
backport-2835-to-release/service/v0.11
Oct 29, 2025
Merged
fix(authz): handle individual resource edge cases in decisions [backport to release/service/v0.11] #2846
jakedoublev
merged 1 commit into
release/service/v0.11
from
backport-2835-to-release/service/v0.11
Oct 29, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
### Proposed Changes Individual resources should be denied for these cases, instead of an overall error response * attribute value FQN not found * registered resource value FQN not found * registered resource missing action attribute values altogether * registered resource missing action attribute values that relate to request action (i.e. `read -> https://example.com/attr/attr1/value/value1` but request was for `delete` action) ### Checklist - [ ] I have added or updated unit tests - [ ] I have added or updated integration tests (if appropriate) - [ ] I have added or updated documentation ### Testing Instructions (cherry picked from commit fad4437)
84f71ed to
e730547
Compare
jakedoublev
approved these changes
Oct 29, 2025
Benchmark results, click to expandBenchmark authorization.GetDecisions Results:
Benchmark authorization.v2.GetMultiResourceDecision Results:
Standard Benchmark Metrics Skipped or FailedBulk Benchmark Results
TDF3 Benchmark Results:
NANOTDF Benchmark Results:
|
Benchmark results, click to expandBenchmark authorization.GetDecisions Results:
Benchmark authorization.v2.GetMultiResourceDecision Results:
Standard Benchmark Metrics Skipped or FailedBulk Benchmark Results
TDF3 Benchmark Results:
NANOTDF Benchmark Results:
|
c-r33d
pushed a commit
that referenced
this pull request
Oct 29, 2025
🤖 I have created a release *beep* *boop* --- ## [0.11.1](service/v0.11.0...service/v0.11.1) (2025-10-29) ### Features * **core:** Actually use KeyManager ProviderConfig [backport to release/service/v0.11] ([#2842](#2842)) ([da1c0b1](da1c0b1)) ### Bug Fixes * **authz:** handle individual resource edge cases in decisions [backport to release/service/v0.11] ([#2846](#2846)) ([a4ad9dd](a4ad9dd)) * **policy:** Return the correct total during list responses. [backport to release/service/v0.11] ([#2843](#2843)) ([ebe6469](ebe6469)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: opentdf-automation[bot] <149537512+opentdf-automation[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Backport of #2835 to
release/service/v0.11.