Conversation
The argument list is copy-pasted from mpath_persistent_reserve_in(3) instead of mpath_persistent_reserve_out(3). Use the correct argument list from libmpathpersist/mpath_persist.h. Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
Commit a04be55 ("multipathd: don't add removed/partial paths to new maps") stopped including INIT_PARTIAL paths in the updated multipath devices built during reconfigure(). During normal multipath operation this does make sense, but isn't necessary (the uevent should still come shortly) and the situation is very unlikely to occur. On the other hand, when multipathd starts up after the pivot root during boot, it's very possible that paths will not be fully initialized. Multipathd should not drops paths in this case. The patch mostly reverts a04be55. Paths that are marked as INIT_REMOVED shouldn't be added in coalesce_paths(). adopt_paths() was already making sure that they weren't before a04be55. But it does make sense to catch those paths earlier in coalesce_paths(), so this patch retains that behavior. Fixes: a04be55 ("multipathd: don't add removed/partial paths to new maps") Signed-off-by: Benjamin Marzinski <bmarzins@redhat.com> Reviewed-by: Martin Wilck <mwilck@suse.com>
Signed-off-by: Martin Wilck <mwilck@suse.com>
bmarzins
approved these changes
Feb 5, 2026
Collaborator
bmarzins
left a comment
bmarzins
left a comment
There was a problem hiding this comment.
Looks good to me. Thanks.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
multipath-tools 0.14.3, 2026/02
Shortlog
@bmarzins (1):
multipathd: fix failures on booting from a multipath device
@mwilck (2):
Update NEWS.md
libmultipath: bump version to 0.14.3
@stefanhaRH (1):
libmpathpersist: fix mpath_persistent_reserve_out(3) synopsis