Skip to content

Remove custom nodesets and use inherited one #135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

cescgina
Copy link
Contributor

@cescgina cescgina commented Apr 4, 2025

After [1] merged the parent ci-framework jobs are using 4.18 crc cloud
nodeset, this change removes the custom nodeset and uses the one from
the parent job.

[1] openstack-k8s-operators/ci-framework#2819

Copy link

openshift-ci bot commented Apr 4, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/33aec48daf3e478b8e0d8dbb51740f9b

✔️ openstack-meta-content-provider-master SUCCESS in 2h 12m 38s
✔️ watcher-operator-validation-master SUCCESS in 1h 59m 14s
watcher-operator-validation-ocp4-16 RETRY_LIMIT in 53m 14s
✔️ noop SUCCESS in 0s
✔️ watcher-operator-validation SUCCESS in 1h 51m 50s
✔️ watcher-operator-kuttl SUCCESS in 44m 15s

@cescgina cescgina force-pushed the use_crc_cloud_nodesets branch from def0ed6 to 2f3c5f6 Compare April 4, 2025 14:52
@cescgina
Copy link
Contributor Author

cescgina commented Apr 4, 2025

Since all the jobs but the 4.16 are working with the crc-cloud change, I'm proposing in this PR making the 4.16 job non-voting until the issues are resolved.

@cescgina cescgina marked this pull request as ready for review April 4, 2025 14:53
@openshift-ci openshift-ci bot requested review from frenzyfriday and raukadah April 4, 2025 14:53
@SeanMooney
Copy link
Collaborator

i would prefer to keep the 4.16 job voting but not move ti to CRC cloud and keep it with extracted until the issue is resovled

@cescgina
Copy link
Contributor Author

cescgina commented Apr 7, 2025

i would prefer to keep the 4.16 job voting but not move ti to CRC cloud and keep it with extracted until the issue is resovled

agreed, we're looking at how to achieve that ,but we need changes in the ci-framework base jobs. Setting it non-voting is a quick way to unblock our CI temporarily, we can decide depending on the urgency and how long the ci-framework changes take

@danpawlik
Copy link

recheck

After [1] merged the parent ci-framework jobs are using 4.18 crc cloud
nodeset, this change removes the custom nodeset and uses the one from
the parent job.

[1] openstack-k8s-operators/ci-framework#2819
@cescgina cescgina force-pushed the use_crc_cloud_nodesets branch from 2f3c5f6 to 43f34b2 Compare April 8, 2025 07:15
@cescgina
Copy link
Contributor Author

cescgina commented Apr 8, 2025

i would prefer to keep the 4.16 job voting but not move ti to CRC cloud and keep it with extracted until the issue is resovled

agreed, we're looking at how to achieve that ,but we need changes in the ci-framework base jobs. Setting it non-voting is a quick way to unblock our CI temporarily, we can decide depending on the urgency and how long the ci-framework changes take

I marked the 4.16 as voting again, we fixed the base job problem and it seems to be working

@amoralej
Copy link
Contributor

amoralej commented Apr 8, 2025

/approve

Copy link

openshift-ci bot commented Apr 8, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: amoralej

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Apr 8, 2025
@amoralej
Copy link
Contributor

amoralej commented Apr 8, 2025

FTR, this is using crc-extracted for 4.16 job:

2025-04-08 07:32:53.467040 | localhost | Distro: RedHat 4.16
2025-04-08 07:32:53.467082 | localhost | Provider: vexxhost-nodepool-tripleo
2025-04-08 07:32:53.467120 | localhost | Label: coreos-crc-extracted-2-39-0-xxl

And crc-cloud for 4.18:

2025-04-08 07:27:08.783898 | localhost | Distro: RedHat 4.18
2025-04-08 07:27:08.783917 | localhost | Provider: vexxhost-nodepool-tripleo
2025-04-08 07:27:08.783934 | localhost | Label: crc-cloud-ocp-4-18-1-xxl

@raukadah
Copy link
Contributor

raukadah commented Apr 8, 2025

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Apr 8, 2025
@openshift-merge-bot openshift-merge-bot bot merged commit aa924aa into openstack-k8s-operators:main Apr 8, 2025
6 checks passed
@cescgina cescgina deleted the use_crc_cloud_nodesets branch April 8, 2025 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants