-
Notifications
You must be signed in to change notification settings - Fork 15
Remove custom nodesets and use inherited one #135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove custom nodesets and use inherited one #135
Conversation
Skipping CI for Draft Pull Request. |
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/33aec48daf3e478b8e0d8dbb51740f9b ✔️ openstack-meta-content-provider-master SUCCESS in 2h 12m 38s |
def0ed6
to
2f3c5f6
Compare
Since all the jobs but the 4.16 are working with the crc-cloud change, I'm proposing in this PR making the 4.16 job non-voting until the issues are resolved. |
i would prefer to keep the 4.16 job voting but not move ti to CRC cloud and keep it with extracted until the issue is resovled |
agreed, we're looking at how to achieve that ,but we need changes in the ci-framework base jobs. Setting it non-voting is a quick way to unblock our CI temporarily, we can decide depending on the urgency and how long the ci-framework changes take |
recheck |
After [1] merged the parent ci-framework jobs are using 4.18 crc cloud nodeset, this change removes the custom nodeset and uses the one from the parent job. [1] openstack-k8s-operators/ci-framework#2819
2f3c5f6
to
43f34b2
Compare
I marked the 4.16 as voting again, we fixed the base job problem and it seems to be working |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: amoralej The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
FTR, this is using crc-extracted for 4.16 job:
And crc-cloud for 4.18:
|
/lgtm |
aa924aa
into
openstack-k8s-operators:main
After [1] merged the parent ci-framework jobs are using 4.18 crc cloud
nodeset, this change removes the custom nodeset and uses the one from
the parent job.
[1] openstack-k8s-operators/ci-framework#2819