Skip to content

[WIP] Remove IronicInspector references <JIRA:OSPRH-36973> - #2078

Closed
mumesan wants to merge 1 commit into
openstack-k8s-operators:mainfrom
mumesan:osprh-36973-remove-inspector-references
Closed

mumesan wants to merge 1 commit into
openstack-k8s-operators:mainfrom
mumesan:osprh-36973-remove-inspector-references

Conversation

@mumesan

@mumesan mumesan commented Sep 15, 2026

Copy link
Copy Markdown
Contributor

Description:
Inspector has been moved from a service to integrate with ironic as an agent, as a result all references to it need to be removed from ironic-operator. This PR removes it in openstack-operator so it compiles successfully when the references are removed from ironic-operator.

@openshift-ci

openshift-ci Bot commented Sep 15, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: mumesan
Once this PR has been reviewed and has the lgtm label, please assign rebtoor for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@coderabbitai

coderabbitai Bot commented Sep 15, 2026

Copy link
Copy Markdown

Important

Review skipped

Ignore keyword(s) in the title.

⛔ Ignored keywords (1)
  • WIP

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Central YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Advanced

Run ID: 8f592cd1-9ca3-4fc4-8f5b-6353a96b9e9c

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Comment @coderabbitai help to get the list of available commands.

@github-actions

Copy link
Copy Markdown

OpenStackControlPlane CRD Size Report

Metric Value
CRD JSON size 336059 bytes (328KB)
Base branch size 338314 bytes
Change -0.67%
Status yellow — growing
Threshold reference
Color Range Meaning
🟢 green < 300KB Comfortable
🟡 yellow 300–400KB Growing
🟠 orange 400–750KB Concerning
🔴 red > 750KB Approaching 1.5MB etcd limit (cut in half to allow space for update)

@openshift-ci

openshift-ci Bot commented Sep 15, 2026

Copy link
Copy Markdown
Contributor

@mumesan: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/precommit-check 428faa3 link true /test precommit-check

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@centosinfra-prod-github-app

Copy link
Copy Markdown

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://gateway-cloud-softwarefactory.apps.ocp.cloud.ci.centos.org/zuul/t/rdoproject.org/buildset/818c9fb437ea496ca708f8e8cb6802af

✔️ openstack-k8s-operators-content-provider SUCCESS in 3h 18m 45s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 23m 22s
✔️ cifmw-crc-podified-edpm-baremetal SUCCESS in 1h 30m 54s
✔️ adoption-standalone-to-crc-ceph-provider SUCCESS in 3h 03m 50s
openstack-operator-tempest-multinode FAILURE in 1h 36m 33s
✔️ openstack-operator-edpm-baremetal-minor-update SUCCESS in 1h 56m 14s

@stuggi

stuggi commented Sep 16, 2026

Copy link
Copy Markdown
Contributor

@mumesan does it mean that inspector is gone and no longer used and there is no migration needed for any config which a user set for it before?

@mumesan

mumesan commented Sep 16, 2026

Copy link
Copy Markdown
Contributor Author

@mumesan does it mean that inspector is gone and no longer used and there is no migration needed for any config which a user set for it before?

Hi @stuggi , we've decided not to proceed with inspector removal from ironic-operator at this time and I'm going to close this PR.
For context on why the PR was created, in the latest version of ironic, it integrates inspector into it as an agent rather than as a standalone service. For now we're going to have both inspector and agent based introspection models as a transition period and remove the inspector code later.

@mumesan mumesan closed this Sep 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants