Use zuul clonned repos for upstream in build_openstack_packages role #2822
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
In build_openstack_packages role for building rpms from gerrit and github, we are clonning the repo and checking out specific change. With these tasks, we are not able to build dlrn rpms if we have multiple prs/crs from same project. But we want to build rpms from all changes. In order to fix, Zuul knows how to checkout proper repos with changes under test and from Depends-on. DLRN always looks for clonned repos in DLRN data directory. In order to use zuul clonned sources with DLRN, We are creating symlink to dlrn data project directory and let's dlrn do the job for upstream repos only. Note: we reverted the similar pr[1] here as original change was lacking proper condition[2] leading to breaking downstream build openstack packages role. By adding proper conditional for upstream, it fixes the issue. Links: [1]. openstack-k8s-operators#2818 [2]. openstack-k8s-operators@f79ca6f#diff-fedeaff036de20345e170c4f65374926975f17139c058369f2e909565054e1adR118-L134 Signed-off-by: Chandan Kumar (raukadah) <[email protected]>
There was a problem hiding this comment.
@raukadah could you pls point me to where you wanted to add the condition (the link for [2] is missing)? I can take a look at that, get that merged and approve this one
Thank you @frenzyfriday for looking into it. We need to add the conditional here: f79ca6f#diff-fedeaff036de20345e170c4f65374926975f17139c058369f2e909565054e1adR118-L134 |
|
/lgtm |
|
Symlinking upstream is fine as it's using --local and not using patch_rebaser 👍 For downstream, we don't symlink and let dlrn to clone the upstream repo, as it's intended to be used to test patches branch not upstream repo. /lgtm |
In build_openstack_packages role for building rpms from gerrit and github, we are clonning the repo and checking out specific change.
With these tasks, we are not able to build dlrn rpms if we have multiple prs/crs from same project.
But we want to build rpms from all changes.
In order to fix, Zuul knows how to checkout proper repos with changes under test and from Depends-on.
DLRN always looks for clonned repos in DLRN data directory. In order to use zuul clonned sources with DLRN, We are creating symlink to dlrn data project directory and let's dlrn do the job for upstream repos only.
Note: we reverted the similar pr[1] here as original change was lacking proper condition[2] leading to breaking downstream build openstack packages role.
By adding proper conditional for upstream, it fixes the issue.
Links:
[1]. #2818
[2]. f79ca6f#diff-fedeaff036de20345e170c4f65374926975f17139c058369f2e909565054e1adR118-L134