-
Notifications
You must be signed in to change notification settings - Fork 120
Set extra mounts for test-operator #2792
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set extra mounts for test-operator #2792
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This PR exposes the extraMounts parameter for all test-operator related CRs (Tempest, Tobiko, AnsibleTest, HorizonTest). This parameter can be used to specify additional volume mounts for the test pods spawned by test-operator.
50e1cf9
to
bbb2f3f
Compare
This patch introduces the ExtraMounts parameter to test-operator. The purpose is to be able to specify PersistentVolumeClaim, Secret, ConfigMap and mount it to the test pod spawned by the test-operator. Depends-On: openstack-k8s-operators/ci-framework#2792
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm!
(I checked, the test-operator role does not have a lot of molecule tests that cover all its variables. It is the same in many of our roles and we have a task on jira to start increasing coverage).
This patch introduces the ExtraMounts parameter to test-operator. The purpose is to be able to specify PersistentVolumeClaim, Secret, ConfigMap and mount it to the test pod spawned by the test-operator. Depends-On: openstack-k8s-operators/ci-framework#2792
This patch introduces the ExtraMounts parameter to test-operator. The purpose is to be able to specify PersistentVolumeClaim, Secret, ConfigMap and mount it to the test pod spawned by the test-operator. Depends-On: openstack-k8s-operators/ci-framework#2792
This patch introduces the ExtraMounts parameter to test-operator. The purpose is to be able to specify PersistentVolumeClaim, Secret, ConfigMap and mount it to the test pod spawned by the test-operator. Depends-On: openstack-k8s-operators/ci-framework#2792
Currently I am trying to test this change in test-operator as part of this https://github.com/openstack-k8s-operators/test-operator/pull/283. For some reason the parameter was not set for test-operator. It could still be fault of the change in test-operator, but just to be sure, I will ping someone to get the second approve after this issue is fixed 😄 |
This patch introduces the ExtraMounts parameter to test-operator. The purpose is to be able to specify PersistentVolumeClaim, Secret, ConfigMap and mount it to the test pod spawned by the test-operator. Depends-On: openstack-k8s-operators/ci-framework#2792
This patch introduces the ExtraMounts parameter to test-operator. The purpose is to be able to specify PersistentVolumeClaim, Secret, ConfigMap and mount it to the test pod spawned by the test-operator. Depends-On: openstack-k8s-operators/ci-framework#2792
This patch introduces the ExtraMounts parameter to test-operator. The purpose is to be able to specify PersistentVolumeClaim, Secret, ConfigMap and mount it to the test pod spawned by the test-operator. Depends-On: openstack-k8s-operators/ci-framework#2792
This PR exposes the extraMounts parameter for all test-operator related CRs (Tempest, Tobiko, AnsibleTest, HorizonTest). This parameter can be used to specify additional volume mounts for the test pods spawned by test-operator.