Skip to content

Set extra mounts for test-operator #2792

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

kstrenkova
Copy link
Contributor

This PR exposes the extraMounts parameter for all test-operator related CRs (Tempest, Tobiko, AnsibleTest, HorizonTest). This parameter can be used to specify additional volume mounts for the test pods spawned by test-operator.

@kstrenkova kstrenkova requested a review from a team as a code owner March 14, 2025 13:30
Copy link
Contributor

openshift-ci bot commented Mar 14, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign abays for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

This PR exposes the extraMounts parameter for all test-operator
related CRs (Tempest, Tobiko, AnsibleTest, HorizonTest). This
parameter can be used to specify additional volume mounts for
the test pods spawned by test-operator.
@kstrenkova kstrenkova force-pushed the extra-mounts-parameters branch from 50e1cf9 to bbb2f3f Compare March 14, 2025 13:31
kstrenkova added a commit to kstrenkova/test-operator that referenced this pull request Mar 14, 2025
This patch introduces the ExtraMounts parameter to test-operator.
The purpose is to be able to specify PersistentVolumeClaim,
Secret, ConfigMap and mount it to the test pod spawned by the
test-operator.

Depends-On: openstack-k8s-operators/ci-framework#2792
Copy link
Collaborator

@frenzyfriday frenzyfriday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm!

(I checked, the test-operator role does not have a lot of molecule tests that cover all its variables. It is the same in many of our roles and we have a task on jira to start increasing coverage).

kstrenkova added a commit to kstrenkova/test-operator that referenced this pull request Mar 17, 2025
This patch introduces the ExtraMounts parameter to test-operator.
The purpose is to be able to specify PersistentVolumeClaim,
Secret, ConfigMap and mount it to the test pod spawned by the
test-operator.

Depends-On: openstack-k8s-operators/ci-framework#2792
kstrenkova added a commit to kstrenkova/test-operator that referenced this pull request Mar 18, 2025
This patch introduces the ExtraMounts parameter to test-operator.
The purpose is to be able to specify PersistentVolumeClaim,
Secret, ConfigMap and mount it to the test pod spawned by the
test-operator.

Depends-On: openstack-k8s-operators/ci-framework#2792
kstrenkova added a commit to kstrenkova/test-operator that referenced this pull request Mar 18, 2025
This patch introduces the ExtraMounts parameter to test-operator.
The purpose is to be able to specify PersistentVolumeClaim,
Secret, ConfigMap and mount it to the test pod spawned by the
test-operator.

Depends-On: openstack-k8s-operators/ci-framework#2792
@kstrenkova
Copy link
Contributor Author

Currently I am trying to test this change in test-operator as part of this https://github.com/openstack-k8s-operators/test-operator/pull/283. For some reason the parameter was not set for test-operator. It could still be fault of the change in test-operator, but just to be sure, I will ping someone to get the second approve after this issue is fixed 😄

kstrenkova added a commit to kstrenkova/test-operator that referenced this pull request Mar 19, 2025
This patch introduces the ExtraMounts parameter to test-operator.
The purpose is to be able to specify PersistentVolumeClaim,
Secret, ConfigMap and mount it to the test pod spawned by the
test-operator.

Depends-On: openstack-k8s-operators/ci-framework#2792
@kstrenkova kstrenkova merged commit 33e7769 into openstack-k8s-operators:main Mar 25, 2025
5 checks passed
kstrenkova added a commit to kstrenkova/test-operator that referenced this pull request Apr 2, 2025
This patch introduces the ExtraMounts parameter to test-operator.
The purpose is to be able to specify PersistentVolumeClaim,
Secret, ConfigMap and mount it to the test pod spawned by the
test-operator.

Depends-On: openstack-k8s-operators/ci-framework#2792
kstrenkova added a commit to kstrenkova/test-operator that referenced this pull request Apr 2, 2025
This patch introduces the ExtraMounts parameter to test-operator.
The purpose is to be able to specify PersistentVolumeClaim,
Secret, ConfigMap and mount it to the test pod spawned by the
test-operator.

Depends-On: openstack-k8s-operators/ci-framework#2792
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants