-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run with GOEXPERIMENT var strictfipsruntime #2643
base: master
Are you sure you want to change the base?
Run with GOEXPERIMENT var strictfipsruntime #2643
Conversation
This commit sets the value of GOEXPERIMENT variable in Containerfile to strictfipsruntime. This change is required to build fips compliant images and is in line with rest of the container files.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jrvaldes, mansikulkarni96 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@@ -10,6 +10,8 @@ ENV GO_COMPLIANCE_DEBUG=0 | |||
# downloading the latest version | |||
ENV GOTOOLCHAIN=local | |||
|
|||
ENV GOEXPERIMENT=strictfipsruntime |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mansikulkarni96 Isn't the Containerfile
used only by konflux? if so, consider overriding the e2e test jobs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, the konflux test isn't passing. Looking into it.
@mansikulkarni96: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
/retest |
@sebsoto does this command works for |
/retest |
This PR sets the value of GOEXPERIMENT variable in Containerfile to strictfipsruntime.
This change is required to build fips compliant images and is in line with rest of the container files.