Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run with GOEXPERIMENT var strictfipsruntime #2643

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mansikulkarni96
Copy link
Member

This PR sets the value of GOEXPERIMENT variable in Containerfile to strictfipsruntime.
This change is required to build fips compliant images and is in line with rest of the container files.

This commit sets the value of GOEXPERIMENT
variable in Containerfile to strictfipsruntime.
This change is required to build fips compliant
images and is in line with rest of the container
files.
@openshift-ci openshift-ci bot requested a review from sebsoto January 23, 2025 20:26
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 23, 2025
Copy link
Contributor

@jrvaldes jrvaldes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 23, 2025
Copy link
Contributor

openshift-ci bot commented Jan 23, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jrvaldes, mansikulkarni96

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@@ -10,6 +10,8 @@ ENV GO_COMPLIANCE_DEBUG=0
# downloading the latest version
ENV GOTOOLCHAIN=local

ENV GOEXPERIMENT=strictfipsruntime
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mansikulkarni96 Isn't the Containerfile used only by konflux? if so, consider overriding the e2e test jobs.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, the konflux test isn't passing. Looking into it.

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 75769cf and 2 for PR HEAD 047b42e in total

Copy link
Contributor

openshift-ci bot commented Jan 23, 2025

@mansikulkarni96: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@sebsoto
Copy link
Contributor

sebsoto commented Jan 24, 2025

/retest

@jrvaldes
Copy link
Contributor

/retest

@sebsoto does this command works for Red Hat Konflux jobs too?

@mansikulkarni96
Copy link
Member Author

/retest

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants