Skip to content

mockgen deprecated: use uber-go/mock instead#194

Open
sebrandon1 wants to merge 1 commit intoopenshift:mainfrom
sebrandon1:mockgen_depreciation
Open

mockgen deprecated: use uber-go/mock instead#194
sebrandon1 wants to merge 1 commit intoopenshift:mainfrom
sebrandon1:mockgen_depreciation

Conversation

@sebrandon1
Copy link
Copy Markdown
Member

https://github.com/golang/mock is marked as archived as of June 27, 2023. They recommend using go.uber.org/mock.

This PR attempts to change the dependency to one that is maintained.

Tracking issue: redhat-best-practices-for-k8s/telco-bot#45

@openshift-ci openshift-ci bot requested review from mpatlasov and rhrmo November 13, 2025 21:18
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Nov 13, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: sebrandon1
Once this PR has been reviewed and has the lgtm label, please assign dfajmon for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 14, 2025
@sebrandon1 sebrandon1 force-pushed the mockgen_depreciation branch from d72ca5f to f75ecbe Compare December 2, 2025 17:02
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 2, 2025
@sebrandon1 sebrandon1 force-pushed the mockgen_depreciation branch from f75ecbe to eb72bcd Compare January 16, 2026 17:36
@sebrandon1 sebrandon1 force-pushed the mockgen_depreciation branch from 470795a to 75ae47f Compare March 20, 2026 19:44
@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Mar 20, 2026

Warning

Rate limit exceeded

@sebrandon1 has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 7 minutes and 17 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 1d4a2df7-9a16-44bb-b253-d51d24784c3b

📥 Commits

Reviewing files that changed from the base of the PR and between acf69b9 and 75ae47f.

⛔ Files ignored due to path filters (11)
  • go.sum is excluded by !**/*.sum
  • vendor/github.com/golang/mock/CONTRIBUTORS is excluded by !vendor/**, !**/vendor/**
  • vendor/go.uber.org/mock/AUTHORS is excluded by !vendor/**, !**/vendor/**
  • vendor/go.uber.org/mock/LICENSE is excluded by !vendor/**, !**/vendor/**
  • vendor/go.uber.org/mock/gomock/call.go is excluded by !vendor/**, !**/vendor/**
  • vendor/go.uber.org/mock/gomock/callset.go is excluded by !vendor/**, !**/vendor/**
  • vendor/go.uber.org/mock/gomock/controller.go is excluded by !vendor/**, !**/vendor/**
  • vendor/go.uber.org/mock/gomock/doc.go is excluded by !vendor/**, !**/vendor/**
  • vendor/go.uber.org/mock/gomock/matchers.go is excluded by !vendor/**, !**/vendor/**
  • vendor/go.uber.org/mock/gomock/string.go is excluded by !vendor/**, !**/vendor/**
  • vendor/modules.txt is excluded by !vendor/**, !**/vendor/**
📒 Files selected for processing (7)
  • go.mod
  • pkg/check/datastore_test.go
  • pkg/check/mock/authmanager_generated.go
  • pkg/check/node_cbt_test.go
  • pkg/check/node_cluster_permissions_test.go
  • pkg/check/permissions.go
  • pkg/check/permissions_test.go
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Mar 20, 2026

@sebrandon1: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/okd-scos-e2e-aws-ovn d72ca5f link false /test okd-scos-e2e-aws-ovn
ci/prow/okd-scos-images 75ae47f link true /test okd-scos-images

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants