NO-JIRA: refactor: Separate custom hooks for re-use#191
NO-JIRA: refactor: Separate custom hooks for re-use#191alanconway wants to merge 1 commit intoopenshift:mainfrom
Conversation
openshift-ci-robot
added
the
jira/valid-reference
|
@alanconway: This pull request explicitly references no jira issue. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alanconway The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
alanconway
force-pushed
the
hook-refactor
branch
from
dcb983e to
da6647a
Compare
| netobserveAvailable: boolean; | ||
| constraint: korrel8r.Constraint; | ||
| }> = ({ domains, graph, loggingAvailable, netobserveAvailable, constraint }) => { | ||
| }> = ({ graph, loggingAvailable, netobserveAvailable, constraint }) => { |
There was a problem hiding this comment.
If we aren't going to use the domains prop anymore lets remove it from the prop type and not pass it in where the component is used
alanconway
force-pushed
the
hook-refactor
branch
from
da6647a to
83d8813
Compare
- useNavigateToQuery - useDomain
alanconway
force-pushed
the
hook-refactor
branch
from
83d8813 to
91aa6e8
Compare
|
/retest |
|
@alanconway: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
3 participants
/cc @PeterYurkovich