Skip to content

DEBUG Do not merge: 10.20 Z stream triggered jobs - #83969

Open
rrasouli wants to merge 1 commit into
openshift:mainfrom
rrasouli:winc-zstream-4.20
Open

DEBUG Do not merge: 10.20 Z stream triggered jobs#83969
rrasouli wants to merge 1 commit into
openshift:mainfrom
rrasouli:winc-zstream-4.20

Conversation

@rrasouli

@rrasouli rrasouli commented Aug 25, 2026

Copy link
Copy Markdown
Contributor

This PR modifies periodic job names so they will trigger by /pj-rehearse new jobs with latest 10.20 image (Z stream)

Summary by CodeRabbit

  • Renamed four Windows Containers test jobs for AWS, GCP, Azure, and vSphere.
  • The new winc-zstream-f14 names trigger /pj-rehearse jobs with the latest 10.20 Z-stream image.
  • Job schedules, steps, environment settings, and workflows remain unchanged.

@coderabbitai

coderabbitai Bot commented Aug 25, 2026

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Pro Plus

Run ID: 29714825-fbf5-4fa6-94b8-b8e96013a3ad

📥 Commits

Reviewing files that changed from the base of the PR and between 06265fd and 67824cb.

⛔ Files ignored due to path filters (1)
  • ci-operator/jobs/openshift/openshift-tests-private/openshift-openshift-tests-private-release-4.20-periodics.yaml is excluded by !ci-operator/jobs/**
📒 Files selected for processing (1)
  • ci-operator/config/openshift/openshift-tests-private/openshift-openshift-tests-private-release-4.20__amd64-nightly.yaml

Included review availability: Your plan provides up to 2 included reviews per hour; 0 remain after this review.


Walkthrough

The change renames four Windows Containers nightly jobs for AWS, GCP, Azure, and vSphere from f14 to zstream-f14. Their schedules and execution configuration remain unchanged.

Changes

Windows Containers job renames

Layer / File(s) Summary
Rename nightly Windows Containers jobs
ci-operator/config/openshift/openshift-tests-private/openshift-openshift-tests-private-release-4.20__amd64-nightly.yaml
Renames the AWS, GCP, Azure, and vSphere job identifiers. Cron, steps, environment, and workflow settings remain unchanged.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk: ⚪ Minimal · up to 67824

The PR changes periodic job names to trigger 10.20 Z-stream rehearsals, and no actionable merge-blocking risk remains beyond normal checks and review.

Suggested reviewers: mgencur, mhanss

🚥 Pre-merge checks | ✅ 15
✅ Passed checks (15 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly identifies the debug purpose and the 10.20 Z-stream triggered jobs. This matches the primary change to rename Windows Containers periodic jobs for Z-stream testing.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed PASS: The pull request changes only four static CI job identifiers from *-winc-f14 to *-winc-zstream-f14 and updates matching generated Prow job names and targets. The diff contains no Ginkgo titl…
Test Structure And Quality ✅ Passed PASS: The pull request changes only four test/job names in the nightly YAML and matching generated periodic-job names and targets. The committed diff contains no Go or Ginkgo test-code changes, so the…
Microshift Test Compatibility ✅ Passed PASS: The pull request adds no Ginkgo e2e tests. The verified diff changes only four test/job names and their generated Prow target references from f14 to zstream-f14; it does not add or modify `I…
Single Node Openshift (Sno) Test Compatibility ✅ Passed PASS: The pull request changes only two YAML files. The diff renames four Windows Containers periodic jobs and their --target values from f14 to zstream-f14; it adds no Ginkgo declarations or te…
Topology-Aware Scheduling Compatibility ✅ Passed PASS: The pull request changes only four CI test target names and their generated periodic-job names/--target arguments. The exact diff shows no deployment manifest, operator code, controller, repli…
Ote Binary Stdout Contract ✅ Passed PASS: The commit changes only two YAML configuration files. The diff renames four periodic job names and matching --target values. It adds no process-level code and contains no stdout, logging, suit…
Ipv6 And Disconnected Network Test Compatibility ✅ Passed PASS: The pull request changes only CI YAML job and target names. The verified commit diff contains no new or modified Ginkgo test declarations or test source. Therefore, the IPv4 and external-connect…
No-Weak-Crypto ✅ Passed The pull request changes only four periodic job names and does not introduce MD5, SHA1, DES, RC4, 3DES, Blowfish, ECB mode, custom cryptography, or non-constant-time secret comparisons.
Container-Privileges ✅ Passed PASS. The pull request changes only four test job names and their matching periodic-job names and targets. The exact diff adds no privileged, hostPID, hostNetwork, hostIPC, SYS_ADMIN, root-user, or al…
No-Sensitive-Data-In-Logs ✅ Passed PASS: The commit changes only four job names and four matching --target identifiers from winc-f14 to winc-zstream-f14. The added lines contain no logging configuration, credentials, tokens, pass…
Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)

Full details: Stable And Deterministic Test Names

Explanation

PASS: The pull request changes only four static CI job identifiers from *-winc-f14 to *-winc-zstream-f14 and updates matching generated Prow job names and targets. The diff contains no Ginkgo title calls or test-title changes, and the new identifiers contain no run-dependent values such as timestamps, UUIDs, node names, namespaces, pod names, or IP addresses.

Full details: Test Structure And Quality

Explanation

PASS: The pull request changes only four test/job names in the nightly YAML and matching generated periodic-job names and targets. The committed diff contains no Go or Ginkgo test-code changes, so the single-responsibility, setup/cleanup, timeout, assertion-message, and test-pattern requirements are not applicable.

Full details: Microshift Test Compatibility

Explanation

PASS: The pull request adds no Ginkgo e2e tests. The verified diff changes only four test/job names and their generated Prow target references from f14 to zstream-f14; it does not add or modify It(), Describe(), Context(), or When() test code. Therefore, the MicroShift API and feature compatibility check has no applicable failure condition.

Full details: Single Node Openshift (Sno) Test Compatibility

Explanation

PASS: The pull request changes only two YAML files. The diff renames four Windows Containers periodic jobs and their --target values from f14 to zstream-f14; it adds no Ginkgo declarations or test logic. Therefore, the SNO compatibility check does not apply.

Full details: Topology-Aware Scheduling Compatibility

Explanation

PASS: The pull request changes only four CI test target names and their generated periodic-job names/--target arguments. The exact diff shows no deployment manifest, operator code, controller, replica, affinity, topology spread, node selector, toleration, or PDB change. The topology-aware scheduling check is therefore not applicable.

Full details: Ote Binary Stdout Contract

Explanation

PASS: The commit changes only two YAML configuration files. The diff renames four periodic job names and matching --target values. It adds no process-level code and contains no stdout, logging, suite-setup, or openshift-tests binary changes. Therefore, it does not introduce an OTE Binary Stdout Contract violation.

Full details: Ipv6 And Disconnected Network Test Compatibility

Explanation

PASS: The pull request changes only CI YAML job and target names. The verified commit diff contains no new or modified Ginkgo test declarations or test source. Therefore, the IPv4 and external-connectivity conditions do not apply.

Full details: Container-Privileges

Explanation

PASS. The pull request changes only four test job names and their matching periodic-job names and targets. The exact diff adds no privileged, hostPID, hostNetwork, hostIPC, SYS_ADMIN, root-user, or allowPrivilegeEscalation settings. No custom-check failure condition was introduced.

Full details: No-Sensitive-Data-In-Logs

Explanation

PASS: The commit changes only four job names and four matching --target identifiers from winc-f14 to winc-zstream-f14. The added lines contain no logging configuration, credentials, tokens, passwords, PII, hostnames, or customer data.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@openshift-ci

openshift-ci Bot commented Aug 25, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rrasouli

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 25, 2026
@openshift-merge-bot

Copy link
Copy Markdown
Contributor

[REHEARSALNOTIFIER]
@rrasouli: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
periodic-ci-openshift-openshift-tests-private-release-4.20-amd64-nightly-aws-ipi-ovn-winc-zstream-f14 N/A periodic Periodic changed
periodic-ci-openshift-openshift-tests-private-release-4.20-amd64-nightly-vsphere-ipi-ovn-winc-zstream-f14 N/A periodic Periodic changed
periodic-ci-openshift-openshift-tests-private-release-4.20-amd64-nightly-gcp-ipi-ovn-winc-zstream-f14 N/A periodic Periodic changed
periodic-ci-openshift-openshift-tests-private-release-4.20-amd64-nightly-azure-ipi-ovn-winc-zstream-f14 N/A periodic Periodic changed

Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@rrasouli

Copy link
Copy Markdown
Contributor Author

/pj-rehearse

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@rrasouli: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci

openshift-ci Bot commented Aug 25, 2026

Copy link
Copy Markdown
Contributor

@rrasouli: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/rehearse/periodic-ci-openshift-openshift-tests-private-release-4.20-amd64-nightly-aws-ipi-ovn-winc-zstream-f14 67824cb link unknown /pj-rehearse periodic-ci-openshift-openshift-tests-private-release-4.20-amd64-nightly-aws-ipi-ovn-winc-zstream-f14
ci/rehearse/periodic-ci-openshift-openshift-tests-private-release-4.20-amd64-nightly-vsphere-ipi-ovn-winc-zstream-f14 67824cb link unknown /pj-rehearse periodic-ci-openshift-openshift-tests-private-release-4.20-amd64-nightly-vsphere-ipi-ovn-winc-zstream-f14
ci/rehearse/periodic-ci-openshift-openshift-tests-private-release-4.20-amd64-nightly-gcp-ipi-ovn-winc-zstream-f14 67824cb link unknown /pj-rehearse periodic-ci-openshift-openshift-tests-private-release-4.20-amd64-nightly-gcp-ipi-ovn-winc-zstream-f14
ci/rehearse/periodic-ci-openshift-openshift-tests-private-release-4.20-amd64-nightly-azure-ipi-ovn-winc-zstream-f14 67824cb link unknown /pj-rehearse periodic-ci-openshift-openshift-tests-private-release-4.20-amd64-nightly-azure-ipi-ovn-winc-zstream-f14

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant