Add verify presubmit for bgp-cloud-connector

[alebedev87]

Summary

• Add a verify presubmit test that runs make verify from the source repo for bgp-cloud-connector.
• Add skip_if_only_changed to the fips-image-scan test so it is skipped on docs-only PRs, consistent with the other code-quality tests.

🤖 Generated with Claude Code

Summary by CodeRabbit

• Adds a verify presubmit test for the bgp-cloud-connector repository.
• Runs make verify in the src container.
• Skips verify and fips-image-scan for documentation-only pull requests.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 0ba545e6-11e4-4a05-ab91-bb91df01ae9f

📥 Commits

Reviewing files that changed from the base of the PR and between 5cdf061 and 7a1628b.

⛔ Files ignored due to path filters (1)

• ci-operator/jobs/openshift/bgp-cloud-connector/openshift-bgp-cloud-connector-main-presubmits.yaml is excluded by !ci-operator/jobs/**

📒 Files selected for processing (1)

• ci-operator/config/openshift/bgp-cloud-connector/openshift-bgp-cloud-connector-main.yaml

🚧 Files skipped from review as they are similar to previous changes (1)

• ci-operator/config/openshift/bgp-cloud-connector/openshift-bgp-cloud-connector-main.yaml

Included review availability: Your plan provides up to 12 included reviews per hour; 11 remain after this review.

---

Walkthrough

The CI configuration adds a verify test step that runs make verify in the src container. The existing documentation-only skip pattern remains in use. The FIPS image scan retains its skip filter.

Changes

CI verification

Layer / File(s)	Summary
Add CI verification test ci-operator/config/openshift/bgp-cloud-connector/openshift-bgp-cloud-connector-main.yaml	The configuration runs make verify in the src container and applies the existing documentation-only skip conditions. The FIPS image scan skip filter remains unchanged.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Merge Risk: ⚪ Minimal · up to 7a162

This PR adds a presubmit verification job and aligns documentation-only skipping for the image scan; no actionable merge-blocking risk remains beyond normal checks and review.

Suggested reviewers: aswinsuryan, frobware

🚥 Pre-merge checks | ✅ 15

✅ Passed checks (15 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly and concisely describes the main change: adding a verify presubmit for bgp-cloud-connector.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names	✅ Passed	PASS: The PR changes only CI YAML and generated Prow job YAML. It adds the static CI name verify and the static job name ...-verify; it adds no Ginkgo It, Describe, Context, or When title.…
Test Structure And Quality	✅ Passed	PASS: The pull request changes only CI configuration and generated presubmit YAML. It adds a make verify job and updates skip_if_only_changed; it does not add or modify Ginkgo test code. Therefore…
Microshift Test Compatibility	✅ Passed	PASS — The pull request changes only CI YAML and the generated presubmit YAML. The diff adds a make verify job and a docs-only skip filter; it adds no Ginkgo e2e tests or test constructors such as `…
Single Node Openshift (Sno) Test Compatibility	✅ Passed	PASS — The commit changes only CI YAML. It adds a make verify job and changes the FIPS scan skip filter. It adds no Ginkgo e2e declarations or cluster-topology assumptions. The existing optional `e2…
Topology-Aware Scheduling Compatibility	✅ Passed	PASS — The pull request changes only CI configuration and the generated Prow presubmit file. The added behavior runs make verify and adds skip_if_only_changed; the diff adds no deployment, operato…
Ote Binary Stdout Contract	✅ Passed	PASS. The pull request changes only two YAML CI configuration files. It adds a make verify step and generated Prow job metadata. It does not change an OTE binary or any process-level code such as `m…
Ipv6 And Disconnected Network Test Compatibility	✅ Passed	PASS: The pull request changes only CI YAML declarations. It adds a make verify presubmit and updates the generated presubmit job. The diff adds no Ginkgo e2e tests, IPv4 assumptions, or external co…
No-Weak-Crypto	✅ Passed	PASS: The pull request changes only CI configuration and generated Prow job configuration. It adds make verify and skip filters. The diff adds no MD5, SHA1, DES, RC4, Blowfish, ECB, custom cryptogra…
Container-Privileges	✅ Passed	PASS. The commit adds the verify CI job and a documentation-only skip rule. The changed source and generated YAML contain no privileged, hostPID, hostNetwork, hostIPC, SYS_ADMIN, `allowPri…
No-Sensitive-Data-In-Logs	✅ Passed	The pull request adds a CI command and skip filters only. The generated job invokes ci-operator --target=verify; it adds no logging statements, output commands, or sensitive-value interpolation. The…

Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)

Full details: Stable And Deterministic Test Names

Explanation

PASS: The PR changes only CI YAML and generated Prow job YAML. It adds the static CI name verify and the static job name ...-verify; it adds no Ginkgo It, Describe, Context, or When title. The source repository’s make verify target performs vendor and version checks and does not run Ginkgo tests.

Full details: Test Structure And Quality

Explanation

PASS: The pull request changes only CI configuration and generated presubmit YAML. It adds a make verify job and updates skip_if_only_changed; it does not add or modify Ginkgo test code. Therefore the listed Ginkgo quality requirements are not applicable.

Full details: Microshift Test Compatibility

Explanation

PASS — The pull request changes only CI YAML and the generated presubmit YAML. The diff adds a make verify job and a docs-only skip filter; it adds no Ginkgo e2e tests or test constructors such as It(), Describe(), Context(), or When(). The MicroShift API compatibility check is therefore not applicable.

Full details: Single Node Openshift (Sno) Test Compatibility

Explanation

PASS — The commit changes only CI YAML. It adds a make verify job and changes the FIPS scan skip filter. It adds no Ginkgo e2e declarations or cluster-topology assumptions. The existing optional e2e-aws configuration remains unchanged, so the SNO compatibility check is not applicable.

Full details: Topology-Aware Scheduling Compatibility

Explanation

PASS — The pull request changes only CI configuration and the generated Prow presubmit file. The added behavior runs make verify and adds skip_if_only_changed; the diff adds no deployment, operator, controller, or scheduling configuration. Therefore, the topology-aware scheduling check is not applicable.

Full details: Ote Binary Stdout Contract

Explanation

PASS. The pull request changes only two YAML CI configuration files. It adds a make verify step and generated Prow job metadata. It does not change an OTE binary or any process-level code such as main(), suite setup, logging, or stdout handling. The stdout contract check is therefore not triggered.

Full details: Ipv6 And Disconnected Network Test Compatibility

Explanation

PASS: The pull request changes only CI YAML declarations. It adds a make verify presubmit and updates the generated presubmit job. The diff adds no Ginkgo e2e tests, IPv4 assumptions, or external connectivity requirements.

Full details: No-Weak-Crypto

Explanation

PASS: The pull request changes only CI configuration and generated Prow job configuration. It adds make verify and skip filters. The diff adds no MD5, SHA1, DES, RC4, Blowfish, ECB, custom cryptography, or secret/token comparison code. Credential and secret names in the generated job are CI plumbing only.

Full details: Container-Privileges

Explanation

PASS. The commit adds the verify CI job and a documentation-only skip rule. The changed source and generated YAML contain no privileged, hostPID, hostNetwork, hostIPC, SYS_ADMIN, allowPrivilegeEscalation, or root user declarations. The new job uses the same standard Kubernetes CI pod shape as the existing jobs.

Full details: No-Sensitive-Data-In-Logs

Explanation

The pull request adds a CI command and skip filters only. The generated job invokes ci-operator --target=verify; it adds no logging statements, output commands, or sensitive-value interpolation. The secret mounts are standard CI configuration and are not logged.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

_{Comment @coderabbitai help to get the list of available commands.}

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alebedev87

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• ci-operator/config/openshift/bgp-cloud-connector/OWNERS [alebedev87]
• ci-operator/jobs/openshift/bgp-cloud-connector/OWNERS [alebedev87]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[alebedev87]

/pj-rehearse

[openshift-merge-bot]

@alebedev87: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

[alebedev87]

/pj-rehearse ack

[openshift-merge-bot]

@alebedev87: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

[alebedev87]

/test config

[alebedev87]

/retest-required

[alebedev87]

/test config

[coderabbitai]

Note

GitHub couldn't provide a complete incremental comparison for this pull request, so CodeRabbit is performing a full review instead. This review may take a little longer.

[openshift-merge-bot]

[REHEARSALNOTIFIER]
@alebedev87: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name	Repo	Type	Reason
pull-ci-openshift-bgp-cloud-connector-main-verify	openshift/bgp-cloud-connector	presubmit	Presubmit changed
pull-ci-openshift-bgp-cloud-connector-main-fips-image-scan	openshift/bgp-cloud-connector	presubmit	Ci-operator config changed

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

[alebedev87]

/pj-rehearse ack

it was just a rebase from latest main done to retrigger config job which didn't respond. No need to re-rehearse.

[openshift-merge-bot]

@alebedev87: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

[openshift-ci]

@alebedev87: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.