NO-ISSUE: e2e-ai-operator-disconnected-capi is working again

[andrej1991]

setting it to mandatory in the master branch
the fixes are still needed to be backported to other branches

Summary by CodeRabbit

The e2e-ai-operator-disconnected-capi test is now mandatory on the master branch for the Assisted Service repository. Related fixes still require backporting to other branches.

[openshift-ci-robot]

@andrej1991: This pull request explicitly references no jira issue.

Details

In response to this:

setting it to mandatory in the master branch
the fixes are still needed to be backported to other branches

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[andrej1991]

/pj-rehearse ack

[openshift-merge-bot]

@andrej1991: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 72965684-6816-4684-a023-075ef40dc026

📥 Commits

Reviewing files that changed from the base of the PR and between 6e4bcaf and f760db5.

⛔ Files ignored due to path filters (1)

• ci-operator/jobs/openshift/assisted-service/openshift-assisted-service-master-presubmits.yaml is excluded by !ci-operator/jobs/**

📒 Files selected for processing (1)

• ci-operator/config/openshift/assisted-service/openshift-assisted-service-master__edge.yaml

💤 Files with no reviewable changes (1)

• ci-operator/config/openshift/assisted-service/openshift-assisted-service-master__edge.yaml

Included review availability: Your plan provides up to 12 included reviews per hour; 11 remain after this review.

---

Walkthrough

The assisted-service edge configuration now treats e2e-ai-operator-disconnected-capi as a required test.

Changes

Assisted-service CI configuration

Layer / File(s)	Summary
Require disconnected CAPI E2E validation ci-operator/config/openshift/assisted-service/openshift-assisted-service-master__edge.yaml	Removes optional: true from e2e-ai-operator-disconnected-capi.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk: ⚪ Minimal · up to f760d

This change is a localized update to enable the assisted-service end-to-end test on the master branch, with no actionable merge-blocking risk remaining beyond normal checks and review.

🚥 Pre-merge checks | ✅ 15

✅ Passed checks (15 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title identifies the affected test and indicates that it is working again, which matches the change that makes the test mandatory on the master branch.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names	✅ Passed	PASS: The pull request changes only CI gating metadata. It removes optional: true from the e2e-ai-operator-disconnected-capi configuration and its generated presubmit job. It does not add or modif…
Test Structure And Quality	✅ Passed	PASS: The pull request changes only CI metadata. It removes optional: true from the e2e-ai-operator-disconnected-capi test declaration and its generated presubmit job. No Ginkgo It blocks or tes…
Microshift Test Compatibility	✅ Passed	PASS — The pull request changes only CI configuration. The diff removes optional: true for e2e-ai-operator-disconnected-capi and updates the generated presubmit configuration. It adds no Ginkgo te…
Single Node Openshift (Sno) Test Compatibility	✅ Passed	PASS: The pull request adds no Ginkgo e2e tests and changes no test body. The exact diff contains only removal of optional: true from the master CI configuration and the corresponding generated pres…
Topology-Aware Scheduling Compatibility	✅ Passed	PASS: The pull request changes only CI metadata. It removes optional: true for e2e-ai-operator-disconnected-capi in the test configuration and generated presubmit job. It does not add or modify de…
Ote Binary Stdout Contract	✅ Passed	The pull request changes only two CI YAML files. It removes optional: true for e2e-ai-operator-disconnected-capi in the master test configuration and generated presubmit job. It does not change OT…
Ipv6 And Disconnected Network Test Compatibility	✅ Passed	PASS: The pull request changes only CI metadata. It removes optional: true from the existing e2e-ai-operator-disconnected-capi target and its generated presubmit job. It does not add or modify any…
No-Weak-Crypto	✅ Passed	PASS. The pull request changes only CI YAML behavior: it removes optional: true from e2e-ai-operator-disconnected-capi and its generated presubmit configuration. The added and removed lines contai…
Container-Privileges	✅ Passed	PASS. The pull request only removes optional: true from the master test configuration and its generated presubmit job. It does not add privileged, hostPID, hostNetwork, hostIPC, SYS_ADMIN, root …
No-Sensitive-Data-In-Logs	✅ Passed	PASS — The pull request only removes optional: true from the disconnected CAPI test configuration and its generated presubmit job. The complete HEAD patch contains two deletions and no logging code,…

Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files.

Full details: Stable And Deterministic Test Names

Explanation

PASS: The pull request changes only CI gating metadata. It removes optional: true from the e2e-ai-operator-disconnected-capi configuration and its generated presubmit job. It does not add or modify any Ginkgo test title, and no dynamic test name is introduced.

Full details: Test Structure And Quality

Explanation

PASS: The pull request changes only CI metadata. It removes optional: true from the e2e-ai-operator-disconnected-capi test declaration and its generated presubmit job. No Ginkgo It blocks or test setup, cleanup, waits, or assertions changed. Therefore, none of the stated Test Structure and Quality failure conditions applies.

Full details: Microshift Test Compatibility

Explanation

PASS — The pull request changes only CI configuration. The diff removes optional: true for e2e-ai-operator-disconnected-capi and updates the generated presubmit configuration. It adds no Ginkgo tests and changes no test bodies, so the MicroShift API compatibility check is not applicable.

Full details: Single Node Openshift (Sno) Test Compatibility

Explanation

PASS: The pull request adds no Ginkgo e2e tests and changes no test body. The exact diff contains only removal of optional: true from the master CI configuration and the corresponding generated presubmit job. The SNO compatibility check is therefore not applicable.

Full details: Topology-Aware Scheduling Compatibility

Explanation

PASS: The pull request changes only CI metadata. It removes optional: true for e2e-ai-operator-disconnected-capi in the test configuration and generated presubmit job. It does not add or modify deployment manifests, operator code, controllers, or scheduling constraints. The topology-aware scheduling check is therefore not applicable.

Full details: Ote Binary Stdout Contract

Explanation

The pull request changes only two CI YAML files. It removes optional: true for e2e-ai-operator-disconnected-capi in the master test configuration and generated presubmit job. It does not change OTE binary code, suite setup, logging, or any stdout write. The stated stdout failure condition is not introduced.

Full details: Ipv6 And Disconnected Network Test Compatibility

Explanation

PASS: The pull request changes only CI metadata. It removes optional: true from the existing e2e-ai-operator-disconnected-capi target and its generated presubmit job. It does not add or modify any Ginkgo test (It(), Describe(), Context(), or When()), IPv4 logic, or external connectivity. The compatibility check is therefore not applicable.

Full details: No-Weak-Crypto

Explanation

PASS. The pull request changes only CI YAML behavior: it removes optional: true from e2e-ai-operator-disconnected-capi and its generated presubmit configuration. The added and removed lines contain no MD5, SHA1, DES, 3DES, RC4, Blowfish, ECB, custom crypto, or secret-comparison logic. No stated weak-crypto failure condition is introduced.

Full details: Container-Privileges

Explanation

PASS. The pull request only removes optional: true from the master test configuration and its generated presubmit job. It does not add privileged, hostPID, hostNetwork, hostIPC, SYS_ADMIN, root execution, or allowPrivilegeEscalation settings. The referenced workflow also contains none of these privilege indicators.

Full details: No-Sensitive-Data-In-Logs

Explanation

PASS — The pull request only removes optional: true from the disconnected CAPI test configuration and its generated presubmit job. The complete HEAD patch contains two deletions and no logging code, log statements, or changes to secret handling. This change does not introduce logging that can expose sensitive data.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

_{Comment @coderabbitai help to get the list of available commands.}

[openshift-merge-bot]

[REHEARSALNOTIFIER]
@andrej1991: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name	Repo	Type	Reason
pull-ci-openshift-assisted-service-master-edge-e2e-ai-operator-disconnected-capi	openshift/assisted-service	presubmit	Presubmit changed

Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

[pastequo]

/lgtm
/approve

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andrej1991, pastequo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• ci-operator/config/openshift/assisted-service/OWNERS [pastequo]
• ci-operator/jobs/openshift/assisted-service/OWNERS [pastequo]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[andrej1991]

/retest

[andrej1991]

/test config

[andrej1991]

/retest

[openshift-ci]

@andrej1991: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.