[WIP] CNTRLPLANE-4170: Port nodepool adding and over-scale tests periodics

[georgelipceanu]

Weekly periodic for e2e v2 for openshift/hypershift#9363

Summary by CodeRabbit

• Adds a weekly MCE periodic for the HyperShift main branch.
• Runs Agent bare-metal HostedCluster E2E v2 tests for connected IPv4 and dual-stack environments.
• Configures required MCE, Konflux, LVM, MetalLB, and dev-scripts test components.
• Adds ownership and metadata for the new CI chain.

[openshift-ci-robot]

@georgelipceanu: This pull request references CNTRLPLANE-4170 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "5.1.0" version, but no target version was set.

Details

In response to this:

Weekly periodic for e2e v2 for openshift/hypershift#9363

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 8f241663-a55a-444e-a432-2a7c0639403c

📥 Commits

Reviewing files that changed from the base of the PR and between b9f267e and 3acae8d.

⛔ Files ignored due to path filters (1)

• ci-operator/jobs/openshift/hypershift/openshift-hypershift-main-periodics.yaml is excluded by !ci-operator/jobs/**

📒 Files selected for processing (4)

• ci-operator/config/openshift/hypershift/openshift-hypershift-main__periodics-mce.yaml
• ci-operator/step-registry/hypershift/mce/agent/e2e-v2/OWNERS
• ci-operator/step-registry/hypershift/mce/agent/e2e-v2/hypershift-mce-agent-e2e-v2-chain.metadata.json
• ci-operator/step-registry/hypershift/mce/agent/e2e-v2/hypershift-mce-agent-e2e-v2-chain.yaml

Included review availability: Your plan provides up to 12 included reviews per hour; 11 remain after this review.

---

Walkthrough

Adds the HyperShift MCE agent E2E v2 chain and schedules connected IPv4 and dual-stack metal conformance periodics with generated MCE configuration.

Changes

HyperShift MCE agent E2E

Layer / File(s)	Summary
Agent E2E v2 chain ci-operator/step-registry/hypershift/mce/agent/e2e-v2/*	Defines the HostedCluster agent E2E v2 chain, filters nodepool-agent tests, emits JUnit output, and sets execution resources and timeouts.
MCE periodic scheduling ci-operator/config/openshift/hypershift/openshift-hypershift-main__periodics-mce.yaml	Adds generated MCE settings and Tuesday and Wednesday scheduled metal tests for connected IPv4 and dual-stack agent environments.

Estimated code review effort: 3 (Moderate) | ~20 minutes

Merge Risk: ⚪ Minimal · up to 3acae

This change adds periodic test configuration without any identified merge-blocking risk; it is merge-ready after normal checks and review.

Sequence Diagram(s)

sequenceDiagram
  participant PeriodicScheduler
  participant MCEPeriodicConfig
  participant MetalWorkflow
  participant AgentE2EChain
  participant GinkgoSuite
  PeriodicScheduler->>MCEPeriodicConfig: select scheduled periodic
  MCEPeriodicConfig->>MetalWorkflow: start connected IPv4 or dual-stack test
  MetalWorkflow->>AgentE2EChain: invoke hypershift-mce-agent-e2e-v2
  AgentE2EChain->>GinkgoSuite: run nodepool-agent tests
  GinkgoSuite-->>MetalWorkflow: return JUnit report

Loading

🚥 Pre-merge checks | ✅ 10

✅ Passed checks (10 passed)

Check name	Status	Explanation
Stable And Deterministic Test Names	✅ Passed	PASS: The pull request adds CI configuration and a chain that invokes bin/test-e2e-v2; it does not add or modify any Ginkgo It, Describe, Context, or When title. The only runtime value is th…
Test Structure And Quality	✅ Passed	PASS: The pull request adds CI YAML, ownership metadata, and a chain that invokes the pre-existing bin/test-e2e-v2 binary. It does not add or modify Ginkgo It, setup, cleanup, assertion, or wait c…
Microshift Test Compatibility	✅ Passed	PASS — The pull request adds CI configuration, a step chain, metadata, and OWNERS only. The diff contains no new Ginkgo test declarations or test source files. The chain invokes the pre-existing `bin/…
Single Node Openshift (Sno) Test Compatibility	✅ Passed	PASS: The committed patch adds CI YAML, JSON, OWNERS, and generated job configuration only. It adds no Go files or new Ginkgo declarations. The new chain invokes the existing bin/test-e2e-v2 suite w…
Topology-Aware Scheduling Compatibility	✅ Passed	PASS. The pull request adds CI periodic configuration, a test chain, ownership metadata, and generated Prow jobs. It does not add or modify deployment manifests, operator code, or controllers. The new…
Ote Binary Stdout Contract	✅ Passed	The pull request changes only YAML, JSON, and OWNERS files. It adds a CI chain that invokes bin/test-e2e-v2 from the pre-existing hypershift-tests image, but it does not add or modify the binary o…
Ipv6 And Disconnected Network Test Compatibility	✅ Passed	PASS: The pull request adds CI YAML, metadata, OWNERS, and a chain that invokes the existing bin/test-e2e-v2 suite. It adds no Ginkgo test source or declarations. The new configuration uses `IP_STAC…
No-Weak-Crypto	✅ Passed	PASS. The pull request adds CI YAML, metadata, OWNERS data, and a shell command that runs an existing e2e binary. The exact added lines contain no MD5, SHA1, DES, 3DES, RC4, Blowfish, or ECB usage. Th…
Container-Privileges	✅ Passed	The pull-request diff adds no prohibited container or Kubernetes security settings. The new periodic configuration and generated Prow jobs contain no privileged: true, host namespace flags, `SYS_ADM…
No-Sensitive-Data-In-Logs	✅ Passed	No sensitive logging was introduced. The new chain only exports a SHA-256-derived cluster name and a fixed namespace, then invokes the existing bin/test-e2e-v2 command. Its --ginkgo.v usage matche…

Full details: Stable And Deterministic Test Names

Explanation

PASS: The pull request adds CI configuration and a chain that invokes bin/test-e2e-v2; it does not add or modify any Ginkgo It, Describe, Context, or When title. The only runtime value is the hosted-cluster name read into E2E_HOSTED_CLUSTER_NAME, which is setup data and not a test title. The added CI identifiers (e2e-v2-agent-connected-ipv4-metal, e2e-v2-agent-connected-dualstack-metal, and hypershift-mce-agent-e2e-v2) are static descriptive names.

Full details: Test Structure And Quality

Explanation

PASS: The pull request adds CI YAML, ownership metadata, and a chain that invokes the pre-existing bin/test-e2e-v2 binary. It does not add or modify Ginkgo It, setup, cleanup, assertion, or wait code. The new CI step also has a 120-minute timeout and 5-minute grace period. Therefore, none of the stated Ginkgo test quality failure conditions applies to the changed code.

Full details: Microshift Test Compatibility

Explanation

PASS — The pull request adds CI configuration, a step chain, metadata, and OWNERS only. The diff contains no new Ginkgo test declarations or test source files. The chain invokes the pre-existing bin/test-e2e-v2 suite with a nodepool-agent label filter, so this check does not apply.

Full details: Single Node Openshift (Sno) Test Compatibility

Explanation

PASS: The committed patch adds CI YAML, JSON, OWNERS, and generated job configuration only. It adds no Go files or new Ginkgo declarations. The new chain invokes the existing bin/test-e2e-v2 suite with a nodepool-agent label filter. The SNO check applies only when new Ginkgo tests are added, so no changed test meets a failure condition.

Full details: Topology-Aware Scheduling Compatibility

Explanation

PASS. The pull request adds CI periodic configuration, a test chain, ownership metadata, and generated Prow jobs. It does not add or modify deployment manifests, operator code, or controllers. The new chain only runs bin/test-e2e-v2; the added configuration contains worker-count test inputs and CI resource requests, but no affinity, topology spread, node selectors, tolerations, replica, rollout, or PDB constraints. The referenced workflows remain unchanged, so their existing scheduling behavior is not introduced by this pull request.

Full details: Ote Binary Stdout Contract

Explanation

The pull request changes only YAML, JSON, and OWNERS files. It adds a CI chain that invokes bin/test-e2e-v2 from the pre-existing hypershift-tests image, but it does not add or modify the binary or any main, suite setup, logging, or stdout-writing code. The new command contains no explicit stdout write. Existing HyperShift chains already invoke the same binary with the same Ginkgo options. Therefore, no stated OTE stdout violation is introduced by this pull request.

Full details: Ipv6 And Disconnected Network Test Compatibility

Explanation

PASS: The pull request adds CI YAML, metadata, OWNERS, and a chain that invokes the existing bin/test-e2e-v2 suite. It adds no Ginkgo test source or declarations. The new configuration uses IP_STACK=v4 for an explicitly IPv4 job and IP_STACK=v4v6 for a dual-stack job; it adds no hardcoded IP address, IPv4-only parser, URL construction, or public endpoint access. The referenced workflow is an existing connected MCE workflow, so this check has no new test implementation to flag.

Full details: No-Weak-Crypto

Explanation

PASS. The pull request adds CI YAML, metadata, OWNERS data, and a shell command that runs an existing e2e binary. The exact added lines contain no MD5, SHA1, DES, 3DES, RC4, Blowfish, or ECB usage. They contain no custom cryptographic implementation and no secret or token comparison. The generated job only adds scheduling and standard CI secret mounts.

Full details: Container-Privileges

Explanation

The pull-request diff adds no prohibited container or Kubernetes security settings. The new periodic configuration and generated Prow jobs contain no privileged: true, host namespace flags, SYS_ADMIN, allowPrivilegeEscalation: true, or explicit root setting. The new e2e chain only defines a test image, command, timeout, and resource requests. The added capabilities: intranet entries are Prow scheduling capabilities, not Linux capabilities.

Full details: No-Sensitive-Data-In-Logs

Explanation

No sensitive logging was introduced. The new chain only exports a SHA-256-derived cluster name and a fixed namespace, then invokes the existing bin/test-e2e-v2 command. Its --ginkgo.v usage matches existing HyperShift e2e-v2 chains. The generated jobs mount standard CI credential files for ci-operator but do not print their contents. The added configuration contains no passwords, tokens, API keys, PII, customer data, or concrete internal hostnames.

✨ Finishing Touches 💡 1

⚔️ Resolve merge conflicts 💡

• Resolve merge conflict in branch non-ui-foundation

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

_{Comment @coderabbitai help to get the list of available commands.}

[openshift-merge-bot]

@georgelipceanu, pj-rehearse: unable to determine affected jobs. This could be due to a branch that needs to be rebased. ERROR:

couldn't prepare candidate: couldn't rebase candidate onto b9f267e82a84eab41c10126eed60f78ffdb72513 due to conflicts

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: georgelipceanu
Once this PR has been reviewed and has the lgtm label, please assign enxebre for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• ci-operator/config/openshift/hypershift/OWNERS
• ci-operator/jobs/openshift/hypershift/OWNERS
• ci-operator/step-registry/hypershift/mce/agent/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci]

@georgelipceanu: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/ci-operator-config-metadata	3acae8d	link	true	/test ci-operator-config-metadata
ci/prow/generated-config	3acae8d	link	true	/test generated-config
ci/prow/yamllint	3acae8d	link	true	/test yamllint
ci/prow/owners	3acae8d	link	true	/test owners
ci/prow/openshift-image-mirror-mappings	3acae8d	link	true	/test openshift-image-mirror-mappings
ci/prow/check-gh-automation	3acae8d	link	true	/test check-gh-automation
ci/prow/prow-config-semantics	3acae8d	link	true	/test prow-config-semantics
ci/prow/core-valid	3acae8d	link	true	/test core-valid
ci/prow/ordered-prow-config	3acae8d	link	true	/test ordered-prow-config
ci/prow/release-controller-config	3acae8d	link	true	/test release-controller-config
ci/prow/config	3acae8d	link	true	/test config
ci/prow/step-registry-metadata	3acae8d	link	true	/test step-registry-metadata
ci/prow/step-registry-shellcheck	3acae8d	link	true	/test step-registry-shellcheck
ci/prow/ci-operator-config	3acae8d	link	true	/test ci-operator-config
ci/prow/prow-config-filenames	3acae8d	link	true	/test prow-config-filenames
ci/prow/ci-operator-registry	3acae8d	link	true	/test ci-operator-registry

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.