stackrox: set timeout on data-router best_effort job

[davdhacs]

best_effort handling requires a timeout on the step: https://docs.ci.openshift.org/architecture/step-registry/#marking-post-steps-best-effort

follow-up to https://github.com/openshift/release/pull/83415/changes

/uncc
/hold

Summary by CodeRabbit

The StackRox Firewatch IPI AWS CR workflow now sets a 15-minute timeout for the mpiit-data-router-reporter best_effort post step. This prevents the Stackrox data-router job from running indefinitely during best_effort step handling.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Pro Plus

Run ID: 99372bb7-9f92-42c5-af05-f807f6b5ca90

📥 Commits

Reviewing files that changed from the base of the PR and between ab3ba3e and b69f6a2.

📒 Files selected for processing (1)

• ci-operator/step-registry/stackrox/firewatch-ipi-aws-cr/stackrox-firewatch-ipi-aws-cr-workflow.yaml

Included review availability: Your plan provides up to 2 included reviews per hour; 0 remain after this review.

---

Walkthrough

The workflow adds a 15-minute timeout to the best-effort mpiit-data-router-reporter post step.

Changes

Firewatch workflow

Layer / File(s)	Summary
Configure reporter timeout ci-operator/step-registry/stackrox/firewatch-ipi-aws-cr/stackrox-firewatch-ipi-aws-cr-workflow.yaml	The mpiit-data-router-reporter post step now uses a 15-minute timeout while retaining best-effort behavior.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk: ⚪ Minimal · up to b69f6

This localized workflow change adds the required timeout for the best-effort job; no actionable merge-blocking risk remains after normal checks and review.

🚥 Pre-merge checks | ✅ 15

✅ Passed checks (15 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly identifies the StackRox data-router best-effort job timeout added by the pull request.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names	✅ Passed	The PR adds only timeout: 15m to a YAML post-step; no Ginkgo test title or dynamic test-name content changed.
Test Structure And Quality	✅ Passed	The commit changes only one workflow YAML line, adding timeout: 15m; it changes no Ginkgo test code or It blocks, so these requirements do not apply.
Microshift Test Compatibility	✅ Passed	The patch changes only a workflow YAML file by adding a 15m timeout; it adds no Ginkgo e2e tests or MicroShift-incompatible API usage.
Single Node Openshift (Sno) Test Compatibility	✅ Passed	The PR changes only one workflow YAML line, adding timeout: 15m; it adds no Ginkgo tests or multi-node assumptions.
Topology-Aware Scheduling Compatibility	✅ Passed	The diff adds only timeout: 15m to a workflow post step; it adds no deployment, controller, manifest, replica, affinity, topology, node, or taint scheduling constraint.
Ote Binary Stdout Contract	✅ Passed	The commit only adds timeout: 15m to a workflow YAML step; it changes no OTE binary or process-level stdout code.
Ipv6 And Disconnected Network Test Compatibility	✅ Passed	The commit changes only one workflow YAML line, adding timeout: 15m; it adds no Ginkgo tests or networking/external-connectivity logic, so this check is inapplicable.
No-Weak-Crypto	✅ Passed	The PR changes only one YAML line, adding timeout: 15m to a best-effort step; no weak cryptography or secret comparison was introduced.
Container-Privileges	✅ Passed	The pull request adds only timeout: 15m to a best-effort post step; it introduces no privileged, host namespace, SYS_ADMIN, root, or privilege-escalation setting.
No-Sensitive-Data-In-Logs	✅ Passed	The PR adds only timeout: 15m to an existing workflow step; it adds no logging or sensitive-data output.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[openshift-merge-bot]

[REHEARSALNOTIFIER]
@davdhacs: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name	Repo	Type	Reason
periodic-ci-stackrox-stackrox-master-ocp-4.22-lpMainline-lp-ocp-compat-cr--acs--tests-aws	N/A	periodic	Registry content changed
periodic-ci-stackrox-stackrox-master-ocp-4.22-lpMainline-lp-ocp-compat-acs--tests-aws-fips	N/A	periodic	Registry content changed

Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

[davdhacs]

/pj-rehearse periodic-ci-stackrox-stackrox-master-ocp-4.22-lpMainline-lp-ocp-compat-cr--acs--tests-aws

[openshift-merge-bot]

@davdhacs: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

[davdhacs]

/pj-rehearse periodic-ci-stackrox-stackrox-master-ocp-4.22-lpMainline-lp-ocp-compat-acs--tests-aws-fips

[openshift-merge-bot]

@davdhacs: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

[davdhacs]

/pj-rehearse periodic-ci-stackrox-stackrox-master-ocp-4.22-lpMainline-lp-ocp-compat-acs--tests-aws-fips

[openshift-merge-bot]

@davdhacs: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

[davdhacs]

/pj-rehearse periodic-ci-stackrox-stackrox-master-ocp-4.22-lpMainline-lp-ocp-compat-cr--acs--tests-aws

[openshift-merge-bot]

@davdhacs: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

[davdhacs]

/pj-rehearse periodic-ci-stackrox-stackrox-master-ocp-4.22-lpMainline-lp-ocp-compat-cr--acs--tests-aws periodic-ci-stackrox-stackrox-master-ocp-4.22-lpMainline-lp-ocp-compat-acs--tests-aws-fips

[openshift-merge-bot]

@davdhacs: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

[davdhacs]

/cc @tommartensen

[davdhacs]

I've run a few rehearsals to try to catch a failure to prove this enables the best_effort condition (no luck yet).

[davdhacs]

/pj-rehearse periodic-ci-stackrox-stackrox-master-ocp-4.22-lpMainline-lp-ocp-compat-cr--acs--tests-aws periodic-ci-stackrox-stackrox-master-ocp-4.22-lpMainline-lp-ocp-compat-acs--tests-aws-fips

[openshift-merge-bot]

@davdhacs: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

[openshift-ci]

@davdhacs: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[tommartensen]

/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: davdhacs, tommartensen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• ci-operator/step-registry/stackrox/firewatch-ipi-aws-cr/OWNERS [davdhacs,tommartensen]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[davdhacs]

/unhold
/pj-rehearse ack

[openshift-merge-bot]

@davdhacs: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.