OCPBUGS-86961: CI job kubevirt-metal-ovn-multinet fails to install MetalLB operator

[amogh-redhat]

What this PR does / why we need it :

The following jobs fails to install MetalLB operator:

https://prow.ci.openshift.org/view/gs/test-platform-results/logs/periodic-ci-openshift-hypershift-release-4.22-periodics-mce-e2e-kubevirt-metal-ovn-multinet/2060843873688621056

https://prow.ci.openshift.org/view/gs/test-platform-results/logs/periodic-ci-openshift-hypershift-release-4.22-periodics-mce-e2e-kubevirt-metal-ovn-multinet-default-net/2060934532646834176

The configurations for the jobs are stored in “ci-operator/config/openshift/hypershift/openshift-hypershift-release-4.22__periodics-mce.yaml” .

METALLB_OPERATOR_SUB_SOURCE variable is missing for the below tests:

e2e-kubevirt-metal-ovn-multinet
e2e-kubevirt-metal-ovn-multinet-default-net

This is the reason why the job looks for METALLB_OPERATOR_SUB_SOURCE value in the workflow yaml - “ci-operator/step-registry/hypershift/mce/kubevirt/baremetalds/conformance/hypershift-mce-kubevirt-baremetalds-conformance-workflow.yaml”.
The METALLB_OPERATOR_SUB_SOURCE value is defined as “qe-app-registry” in the workflow yaml.
This is causing the error, as the OLM operator couldn’t find “metallb-operator” in “qe-app-registry”.
To fix this, i have adds the “METALLB_OPERATOR_SUB_SOURCE: metallb-konflux” for both the tests mentioned above under the “env:”.

Other tests that are running for the same version already have this variable under "env".
example - e2e-kubevirt-metal-ovn, e-agent-connected-ovn-ipv4-metal-conformance.

Which issue(s) this PR fixes: Fixes - https://redhat.atlassian.net/browse/OCPBUGS-86961

Special notes for your reviewer:

Checklist:
Subject and description added to both, commit and PR.
Relevant issues have been referenced.
This change includes docs.
This change includes unit tests.

Summary by CodeRabbit

This PR fixes periodic CI job failures in the OpenShift HyperShift MCE (Multicluster Engine) testing pipeline. Two KubeVirt BareMetalDS conformance tests—e2e-kubevirt-metal-ovn-multinet and e2e-kubevirt-metal-ovn-multinet-default-net—were failing to install the MetalLB operator during their execution.

The root cause was a missing environment variable in the job configuration. These tests rely on a workflow that installs MetalLB, but without the METALLB_OPERATOR_SUB_SOURCE variable explicitly set, it defaults to qe-app-registry where the metallb-operator is not available, causing OLM installation to fail.

The fix adds METALLB_OPERATOR_SUB_SOURCE: metallb-konflux to both job configurations in the HyperShift MCE periodic jobs manifest (openshift-hypershift-release-4.22__periodics-mce.yaml). This aligns them with other similar tests for the same release that already have this variable configured.

Impact: Resolves installation failures in periodic CI tests for HyperShift's KubeVirt multinetwork conformance testing, allowing the MetalLB operator to be properly sourced from the correct operator registry during test execution.

[openshift-ci]

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

[openshift-ci-robot]

@amogh-redhat: This pull request references Jira Issue OCPBUGS-86961, which is invalid:

• expected the bug to target the "5.0.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

What this PR does / why we need it :

The following jobs fails to install MetalLB operator:

https://prow.ci.openshift.org/view/gs/test-platform-results/logs/periodic-ci-openshift-hypershift-release-4.22-periodics-mce-e2e-kubevirt-metal-ovn-multinet/2060843873688621056

https://prow.ci.openshift.org/view/gs/test-platform-results/logs/periodic-ci-openshift-hypershift-release-4.22-periodics-mce-e2e-kubevirt-metal-ovn-multinet-default-net/2060934532646834176

The configurations for the jobs are stored in “ci-operator/config/openshift/hypershift/openshift-hypershift-release-4.22__periodics-mce.yaml” .

METALLB_OPERATOR_SUB_SOURCE variable is missing for the below tests:

e2e-kubevirt-metal-ovn-multinet
e2e-kubevirt-metal-ovn-multinet-default-net

This is the reason why the job looks for METALLB_OPERATOR_SUB_SOURCE value in the workflow yaml - “ci-operator/step-registry/hypershift/mce/kubevirt/baremetalds/conformance/hypershift-mce-kubevirt-baremetalds-conformance-workflow.yaml”.
The METALLB_OPERATOR_SUB_SOURCE value is defined as “qe-app-registry” in the workflow yaml.
This is causing the error, as the OLM operator couldn’t find “metallb-operator” in “qe-app-registry”.
To fix this, i have adds the “METALLB_OPERATOR_SUB_SOURCE: metallb-konflux” for both the tests mentioned above under the “env:”.

Other tests that are running for the same version already have this variable under "env".
example - e2e-kubevirt-metal-ovn, e-agent-connected-ovn-ipv4-metal-conformance.

Which issue(s) this PR fixes: Fixes - https://redhat.atlassian.net/browse/OCPBUGS-86961

Special notes for your reviewer:
Checklist:
Subject and description added to both, commit and PR.
Relevant issues have been referenced.
This change includes docs.
This change includes unit tests.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 5118ac63-56e4-4c7a-b5be-6458bda3ef2b

📥 Commits

Reviewing files that changed from the base of the PR and between 5adb631 and 4075b2f.

📒 Files selected for processing (1)

• ci-operator/config/openshift/hypershift/openshift-hypershift-release-4.22__periodics-mce.yaml

---

Walkthrough

This PR updates the hypershift MCE periodic Prow job configuration to add the METALLB_OPERATOR_SUB_SOURCE: metallb-konflux environment variable to two KubeVirt BareMetalMultiNet test variants, specifying the Konflux source for the MetalLB operator in the test environment.

Changes

MCE MetalLB Operator Environment Configuration

Layer / File(s)	Summary
MetalLB operator source environment configuration ci-operator/config/openshift/hypershift/openshift-hypershift-release-4.22__periodics-mce.yaml	Adds METALLB_OPERATOR_SUB_SOURCE: metallb-konflux to the env block for both the e2e-kubevirt-metal-ovn-multinet and e2e-kubevirt-metal-ovn-multinet-default-net test jobs.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

• openshift/release#78382: Updates the same hypershift MCE Konflux operator environment configuration for METALLB_OPERATOR_SUB_SOURCE in the same Prow job configuration file.

Suggested labels

lgtm

Suggested reviewers

• csrwng

🚥 Pre-merge checks | ✅ 15

✅ Passed checks (15 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately describes the main change: fixing CI job failures by adding a missing environment variable for MetalLB operator installation.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names	✅ Passed	PR modifies only CI job configuration YAML, not Ginkgo test code. The check for "Stable and Deterministic Test Names" applies to Ginkgo test definitions in Go code, which this PR does not modify.
Test Structure And Quality	✅ Passed	This PR only contains YAML configuration changes (54,165 .yaml files), not Ginkgo test code. The custom check is specifically for reviewing Ginkgo test quality and is not applicable here.
Microshift Test Compatibility	✅ Passed	PR modifies only CI configuration (YAML file) to update environment variables; no new Ginkgo e2e tests are added, so check does not apply.
Single Node Openshift (Sno) Test Compatibility	✅ Passed	This PR modifies only YAML CI configuration, not test code. The SNO compatibility check applies when new Ginkgo e2e tests are added; no test code changes present.
Topology-Aware Scheduling Compatibility	✅ Passed	PR modifies only a Prow CI job configuration file to add an environment variable for test execution. No deployment manifests, operator code, controllers, or scheduling constraints are modified.
Ote Binary Stdout Contract	✅ Passed	PR modifies only CI job YAML configuration files, not OTE binary code. The OTE stdout contract check applies to Go code in test binaries, not configuration files.
Ipv6 And Disconnected Network Test Compatibility	✅ Passed	PR only modifies Prow job configuration (YAML), not new Ginkgo e2e tests. Custom check only applies when new tests are added.
No-Weak-Crypto	✅ Passed	PR modifies only YAML CI configuration file; no cryptographic code, weak crypto algorithms, or insecure implementations present.
Container-Privileges	✅ Passed	PR modifies only a Prow CI job configuration file adding environment variables; no container privilege escalation, privileged mode, hostPID/Network/IPC, or related security issues present.
No-Sensitive-Data-In-Logs	✅ Passed	The PR adds only a catalog source name (metallb-konflux) to environment variables. No passwords, tokens, API keys, PII, session IDs, or other sensitive data are exposed.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: amogh-redhat
Once this PR has been reviewed and has the lgtm label, please assign sjenning for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• ci-operator/config/openshift/hypershift/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-merge-bot]

[REHEARSALNOTIFIER]
@amogh-redhat: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name	Repo	Type	Reason
periodic-ci-openshift-hypershift-release-4.22-periodics-mce-e2e-kubevirt-metal-ovn-multinet	N/A	periodic	Ci-operator config changed
periodic-ci-openshift-hypershift-release-4.22-periodics-mce-e2e-kubevirt-metal-ovn-multinet-default-net	N/A	periodic	Ci-operator config changed

Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.