Skip to content

testing a fix#80165

Draft
andrej1991 wants to merge 1 commit into
openshift:mainfrom
andrej1991:fix-sno-late-bind-4-22
Draft

testing a fix#80165
andrej1991 wants to merge 1 commit into
openshift:mainfrom
andrej1991:fix-sno-late-bind-4-22

Conversation

@andrej1991
Copy link
Copy Markdown
Contributor

@andrej1991 andrej1991 commented Jun 5, 2026

Summary by CodeRabbit

This PR updates the CI configuration for the assisted-test-infra repository to reference OpenShift 5.0 nightly releases instead of 4.22. Specifically, it modifies the version specified in the releases.latest and releases.latest-multi candidate blocks to pull from the OCP 5.0 nightly stream rather than 4.22, affecting which OpenShift release version is used when running tests and CI jobs for this infrastructure component.

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Jun 5, 2026

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci openshift-ci Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 5, 2026
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Jun 5, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 35db2f29-b338-4dbe-a34c-79d61f5dd434

📥 Commits

Reviewing files that changed from the base of the PR and between 5adb631 and 7abb24d.

⛔ Files ignored due to path filters (3)
  • ci-operator/jobs/openshift/assisted-test-infra/openshift-assisted-test-infra-master-periodics.yaml is excluded by !ci-operator/jobs/**
  • ci-operator/jobs/openshift/assisted-test-infra/openshift-assisted-test-infra-master-postsubmits.yaml is excluded by !ci-operator/jobs/**
  • ci-operator/jobs/openshift/assisted-test-infra/openshift-assisted-test-infra-master-presubmits.yaml is excluded by !ci-operator/jobs/**
📒 Files selected for processing (1)
  • ci-operator/config/openshift/assisted-test-infra/openshift-assisted-test-infra-master.yaml

Walkthrough

This PR updates the assisted-test-infra CI configuration to reference OpenShift release version 5.0 instead of 4.22 for the latest and latest-multi release candidates, maintaining the existing OCP nightly stream and architecture configurations.

Changes

CI Configuration Release Version Update

Layer / File(s) Summary
Release version update
ci-operator/config/openshift/assisted-test-infra/openshift-assisted-test-infra-master.yaml
The releases configuration for latest and latest-multi candidates updates version from "4.22" to "5.0" while maintaining OCP nightly stream and multi-architecture selectors.

🎯 1 (Trivial) | ⏱️ ~2 minutes

🚥 Pre-merge checks | ✅ 14 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Title check ❓ Inconclusive The title 'testing a fix' is vague and generic, lacking specificity about what is being fixed or tested in the changeset. Consider using a more descriptive title that clearly indicates the specific change, such as 'Update assisted-test-infra releases from 4.22 to 5.0' or similar.
✅ Passed checks (14 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed PR modifies only YAML configuration files, not Ginkgo test code. No test names to validate, making this check not applicable.
Test Structure And Quality ✅ Passed The custom check for Ginkgo test code quality is not applicable to this PR; the PR only modifies YAML CI configuration, not test code.
Microshift Test Compatibility ✅ Passed PR modifies only CI/OpenShift configuration YAML (release versions and Docker image refs); no new Ginkgo e2e tests are added, so the MicroShift test compatibility check does not apply.
Single Node Openshift (Sno) Test Compatibility ✅ Passed No new Ginkgo e2e tests added. PR only modifies YAML CI/CD configuration files (version bumps and job definitions), not test code.
Topology-Aware Scheduling Compatibility ✅ Passed PR modifies only CI configuration (test job versions), not deployment manifests, operator code, or controllers. No scheduling constraints introduced; check does not apply.
Ote Binary Stdout Contract ✅ Passed PR modifies only YAML configuration (version 4.22→5.0), no code changes. OTE stdout violations only occur in process-level code; check is not applicable.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed This PR only modifies a CI configuration YAML file (updating release versions from 4.22 to 5.0). No Ginkgo e2e tests are added or modified, so the custom check does not apply.
No-Weak-Crypto ✅ Passed PR changes only CI/OpenShift YAML configuration file; no cryptographic code, weak crypto usage (MD5, SHA1, DES, RC4, 3DES, Blowfish, ECB), custom crypto, or secret comparison issues present.
Container-Privileges ✅ Passed File is CI operator config (not K8s manifest) with no privileged, hostPID, hostNetwork, hostIPC, SYS_ADMIN, allowPrivilegeEscalation, or root user settings.
No-Sensitive-Data-In-Logs ✅ Passed YAML config file contains only standard CI/test infrastructure settings with no passwords, tokens, API keys, PII, or sensitive data exposed in logs or environment variables.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Jun 5, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: andrej1991
Once this PR has been reviewed and has the lgtm label, please assign gamli75 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@andrej1991
Copy link
Copy Markdown
Contributor Author

/pj-rehearse periodic-ci-openshift-assisted-test-infra-master-e2e-metal-assisted-kube-api-late-binding-sno-4-22-periodic

@openshift-merge-bot
Copy link
Copy Markdown
Contributor

@andrej1991: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-merge-bot
Copy link
Copy Markdown
Contributor

[REHEARSALNOTIFIER]
@andrej1991: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-assisted-test-infra-master-ansible-lint openshift/assisted-test-infra presubmit Ci-operator config changed
pull-ci-openshift-assisted-test-infra-master-e2e-metal-assisted-4-16 openshift/assisted-test-infra presubmit Ci-operator config changed
pull-ci-openshift-assisted-test-infra-master-e2e-metal-assisted-4-17 openshift/assisted-test-infra presubmit Ci-operator config changed
pull-ci-openshift-assisted-test-infra-master-e2e-metal-assisted-4-18 openshift/assisted-test-infra presubmit Ci-operator config changed
pull-ci-openshift-assisted-test-infra-master-e2e-metal-assisted-4-19 openshift/assisted-test-infra presubmit Ci-operator config changed
pull-ci-openshift-assisted-test-infra-master-e2e-metal-assisted-4-22 openshift/assisted-test-infra presubmit Ci-operator config changed
pull-ci-openshift-assisted-test-infra-master-e2e-metal-assisted-bond-4-22 openshift/assisted-test-infra presubmit Ci-operator config changed
pull-ci-openshift-assisted-test-infra-master-e2e-metal-assisted-day2-4-22 openshift/assisted-test-infra presubmit Ci-operator config changed
pull-ci-openshift-assisted-test-infra-master-e2e-metal-assisted-day2-arm-workers-4-22 openshift/assisted-test-infra presubmit Ci-operator config changed
pull-ci-openshift-assisted-test-infra-master-e2e-metal-assisted-day2-sno-4-22 openshift/assisted-test-infra presubmit Ci-operator config changed
pull-ci-openshift-assisted-test-infra-master-e2e-metal-assisted-dual-primary-v6-compact-4-22 openshift/assisted-test-infra presubmit Ci-operator config changed
pull-ci-openshift-assisted-test-infra-master-e2e-metal-assisted-dual-stack-primary-ipv6-4-22 openshift/assisted-test-infra presubmit Ci-operator config changed
pull-ci-openshift-assisted-test-infra-master-e2e-metal-assisted-external-4-22 openshift/assisted-test-infra presubmit Ci-operator config changed
pull-ci-openshift-assisted-test-infra-master-e2e-metal-assisted-ha-kube-api-ipv4-4-22 openshift/assisted-test-infra presubmit Ci-operator config changed
pull-ci-openshift-assisted-test-infra-master-e2e-metal-assisted-ha-kube-api-ipv6-4-22 openshift/assisted-test-infra presubmit Ci-operator config changed
pull-ci-openshift-assisted-test-infra-master-e2e-metal-assisted-ipv4v6-4-22 openshift/assisted-test-infra presubmit Ci-operator config changed
pull-ci-openshift-assisted-test-infra-master-e2e-metal-assisted-ipv6-4-22 openshift/assisted-test-infra presubmit Ci-operator config changed
pull-ci-openshift-assisted-test-infra-master-e2e-metal-assisted-ipxe-4-22 openshift/assisted-test-infra presubmit Ci-operator config changed
pull-ci-openshift-assisted-test-infra-master-e2e-metal-assisted-kube-api-late-binding-sno-4-22 openshift/assisted-test-infra presubmit Ci-operator config changed
pull-ci-openshift-assisted-test-infra-master-e2e-metal-assisted-kube-api-late-unbinding-sno-4-22 openshift/assisted-test-infra presubmit Ci-operator config changed
pull-ci-openshift-assisted-test-infra-master-e2e-metal-assisted-kube-api-reclaim-4-22 openshift/assisted-test-infra presubmit Ci-operator config changed
pull-ci-openshift-assisted-test-infra-master-e2e-metal-assisted-kube-api-reclaim-sno-4-22 openshift/assisted-test-infra presubmit Ci-operator config changed
pull-ci-openshift-assisted-test-infra-master-e2e-metal-assisted-kube-api-umlb-4-22 openshift/assisted-test-infra presubmit Ci-operator config changed
pull-ci-openshift-assisted-test-infra-master-e2e-metal-assisted-lvm-4-22 openshift/assisted-test-infra presubmit Ci-operator config changed
pull-ci-openshift-assisted-test-infra-master-e2e-metal-assisted-mce-4-22 openshift/assisted-test-infra presubmit Ci-operator config changed

A total of 88 jobs have been affected by this change. The above listing is non-exhaustive and limited to 25 jobs.

A full list of affected jobs can be found here
Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Jun 5, 2026

@andrej1991: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant