Skip to content

PowerVC: Use version 2.4.1 of ocp-ipi-powervc#80163

Open
hamzy wants to merge 1 commit into
openshift:mainfrom
hamzy:PowerVC-use-version-2-4-1
Open

PowerVC: Use version 2.4.1 of ocp-ipi-powervc#80163
hamzy wants to merge 1 commit into
openshift:mainfrom
hamzy:PowerVC-use-version-2-4-1

Conversation

@hamzy
Copy link
Copy Markdown
Contributor

@hamzy hamzy commented Jun 5, 2026

Use version 2.4.1 of ocp-ipi-powervc

Summary by CodeRabbit

This PR updates the OpenShift CI infrastructure to use PowerVC-Tool version 2.4.1 instead of 2.3.8. The changes affect three PowerVC-related step registry scripts used for IPI (Installer Provisioned Infrastructure) operations:

Configuration changes (ipi-conf-powervc-commands.sh):

  • Updated PowerVC-Tool version to v2.4.1
  • Modified RHCOS image verification logic to use the new PowerVC-Tool rhcos-exists command instead of direct OpenStack API calls (image show/image list)

Installation changes (ipi-install-powervc-install-commands.sh):

  • Updated PowerVC-Tool version to v2.4.1 for the download URL

Deprovisioning changes (ipi-deprovision-deprovision-powervc-deprovision-commands.sh):

  • Updated PowerVC-Tool version to v2.4.1 for the download URL

The version bump standardizes the PowerVC-Tool across all three CI pipeline stages, with an additional improvement to the image verification workflow that delegates RHCOS image checks to PowerVC-Tool's dedicated command.

Use version 2.4.1 of ocp-ipi-powervc
@openshift-ci openshift-ci Bot requested review from amrutp-redhat and mjturek June 5, 2026 16:15
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Jun 5, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 090131d4-4500-4771-8a83-757e10e9d7a1

📥 Commits

Reviewing files that changed from the base of the PR and between a596c64 and 2db2c8a.

📒 Files selected for processing (3)
  • ci-operator/step-registry/ipi/conf/powervc/ipi-conf-powervc-commands.sh
  • ci-operator/step-registry/ipi/deprovision/deprovision/powervc/deprovision/ipi-deprovision-deprovision-powervc-deprovision-commands.sh
  • ci-operator/step-registry/ipi/install/powervc/install/ipi-install-powervc-install-commands.sh

Walkthrough

Three PowerVC IPI step scripts are updated to use PowerVC-Tool version v2.4.1 instead of v2.3.8. The config script additionally refactors RHCOS image verification to call PowerVC-Tool's rhcos-exists subcommand with configured cloud and image name parameters instead of using OpenStack image queries.

Changes

PowerVC Infrastructure Updates

Layer / File(s) Summary
PowerVC-Tool v2.4.1 version updates
ci-operator/step-registry/ipi/install/powervc/install/ipi-install-powervc-install-commands.sh, ci-operator/step-registry/ipi/conf/powervc/ipi-conf-powervc-commands.sh, ci-operator/step-registry/ipi/deprovision/deprovision/powervc/deprovision/ipi-deprovision-deprovision-powervc-deprovision-commands.sh
The POWERVC_TOOL_VERSION constant is updated from v2.3.8 to v2.4.1 across all three scripts, changing which PowerVC-Tool release is downloaded and used during install, config, and deprovision phases.
RHCOS image verification refactoring
ci-operator/step-registry/ipi/conf/powervc/ipi-conf-powervc-commands.sh
RHCOS image existence verification is refactored to invoke PowerVC-Tool rhcos-exists with --cloud and --imageName parameters, replacing the previous OpenStack image show/list commands while maintaining the same failure behavior on missing images.

🎯 2 (Simple) | ⏱️ ~8 minutes

🚥 Pre-merge checks | ✅ 15
✅ Passed checks (15 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The pull request title 'PowerVC: Use version 2.4.1 of ocp-ipi-powervc' clearly and concisely summarizes the main change: updating PowerVC-Tool from v2.3.8 to v2.4.1 across three CI/CD scripts.
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed This PR modifies only shell scripts for PowerVC infrastructure provisioning and does not contain any Ginkgo test code, making this check not applicable to the PR.
Test Structure And Quality ✅ Passed PR contains no Ginkgo test code changes; custom check for Ginkgo test quality is not applicable to shell script PowerVC version updates.
Microshift Test Compatibility ✅ Passed This PR updates shell scripts for PowerVC tool version from v2.3.8 to v2.4.1. No new Ginkgo e2e tests are added; check does not apply.
Single Node Openshift (Sno) Test Compatibility ✅ Passed No new Ginkgo e2e tests are added. PR only updates PowerVC-Tool version (v2.3.8→v2.4.1) in three shell provisioning scripts.
Topology-Aware Scheduling Compatibility ✅ Passed PR updates PowerVC-Tool version in CI helper scripts; contains no Kubernetes deployment manifests, operators, or scheduling constraints affecting pod topology.
Ote Binary Stdout Contract ✅ Passed PR modifies bash shell scripts for PowerVC CI/CD, not Go test binaries. OTE Binary Stdout Contract applies only to Go/Ginkgo code, which is not present here.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed This PR contains no Ginkgo e2e tests. It only updates shell scripts in the CI operator step registry to use PowerVC-Tool version 2.4.1. The check is not applicable.
No-Weak-Crypto ✅ Passed PR contains no weak cryptography: no MD5/SHA1/DES/RC4/Blowfish/ECB detected; uses SHA-256 for signature verification which is secure.
Container-Privileges ✅ Passed The PR modifies only shell scripts that update PowerVC-Tool version. No Kubernetes manifests or container security configurations are modified or added with privileged settings.
No-Sensitive-Data-In-Logs ✅ Passed No sensitive data (passwords, tokens, API keys, PII) exposed in logs. API keys and credentials are not logged with their values, only infrastructure identifiers.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Jun 5, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hamzy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 5, 2026
@openshift-merge-bot
Copy link
Copy Markdown
Contributor

[REHEARSALNOTIFIER]
@hamzy: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
periodic-ci-openshift-multiarch-main-nightly-4.23-ocp-e2e-ovn-powervc-multi-p-p N/A periodic Registry content changed
periodic-ci-openshift-multiarch-main-nightly-4.21-ocp-e2e-ovn-powervc-multi-p-p N/A periodic Registry content changed
periodic-ci-openshift-multiarch-main-nightly-4.22-ocp-e2e-ovn-powervc-multi-p-p N/A periodic Registry content changed
periodic-ci-openshift-multiarch-main-nightly-5.0-ocp-e2e-ovn-powervc-multi-p-p N/A periodic Registry content changed

Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@hamzy
Copy link
Copy Markdown
Contributor Author

hamzy commented Jun 5, 2026

/pj-rehearse periodic-ci-openshift-multiarch-main-nightly-4.23-ocp-e2e-ovn-powervc-multi-p-p

@openshift-merge-bot
Copy link
Copy Markdown
Contributor

@hamzy: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Jun 5, 2026

@hamzy: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/rehearse/periodic-ci-openshift-multiarch-main-nightly-4.23-ocp-e2e-ovn-powervc-multi-p-p 2db2c8a link unknown /pj-rehearse periodic-ci-openshift-multiarch-main-nightly-4.23-ocp-e2e-ovn-powervc-multi-p-p

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant