-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
projects: Add fedora-okd-builder container and ImageStream #5533
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: LorbusChris The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
I'm confused what this is for. |
The golang builder should be sufficient as is. |
I'd like to avoid using RPMs that weren't built on a Fedora system in FCoS, as I am unsure of the implications this might have. |
If this is not seen as a necessary precaution, I will go ahead and add CI jobs for RPM builds on the centos base. |
see also: openshift/enhancements#78 (comment) |
Ultimately these are being consumed from CI infra and available freely today - there may be specific places where we want to duplicate, or make it even easier for someone to recreate on their own, but I don't see a huge incentive to do that NOW vs at a point where we have to. |
This PR is certainly useful, but not right now. Rebuilding rpms with f30 would most likely require updates to specs - that might take quite a while to do correctly. For now its fine to use centos builder for RPMs - all binaries are golang anyway, they seem to run fine on F30 |
Alright then. |
@LorbusChris: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
This PR adds a
fedora-okd-builder
Dockerfile and ImageStream to use as build environment for OKD-on-FCoS components on Prow.Right now, the configured repository to push to is
docker.io/openshift/fedora-okd-builder
, which will have to be created, if we agree on the naming