Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

projects: Add fedora-okd-builder container and ImageStream #5533

Closed
wants to merge 1 commit into from

Conversation

LorbusChris
Copy link
Member

@LorbusChris LorbusChris commented Oct 21, 2019

This PR adds a fedora-okd-builder Dockerfile and ImageStream to use as build environment for OKD-on-FCoS components on Prow.

Right now, the configured repository to push to is docker.io/openshift/fedora-okd-builder, which will have to be created, if we agree on the naming

@openshift-ci-robot openshift-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Oct 21, 2019
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: LorbusChris
To complete the pull request process, please assign alexnpavel
You can assign the PR to them by writing /assign @alexnpavel in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@smarterclayton
Copy link
Contributor

I'm confused what this is for.

@smarterclayton
Copy link
Contributor

The golang builder should be sufficient as is.

@LorbusChris
Copy link
Member Author

I'd like to avoid using RPMs that weren't built on a Fedora system in FCoS, as I am unsure of the implications this might have.
(in order to stay as close to Fedora's packaging guidelines as possible, now that we are already not using Koji to run the builds for these RPMs)

@LorbusChris
Copy link
Member Author

If this is not seen as a necessary precaution, I will go ahead and add CI jobs for RPM builds on the centos base.

@LorbusChris
Copy link
Member Author

see also: openshift/enhancements#78 (comment)

@smarterclayton
Copy link
Contributor

Ultimately these are being consumed from CI infra and available freely today - there may be specific places where we want to duplicate, or make it even easier for someone to recreate on their own, but I don't see a huge incentive to do that NOW vs at a point where we have to.

@vrutkovs
Copy link
Member

This PR is certainly useful, but not right now. Rebuilding rpms with f30 would most likely require updates to specs - that might take quite a while to do correctly.

For now its fine to use centos builder for RPMs - all binaries are golang anyway, they seem to run fine on F30

@LorbusChris
Copy link
Member Author

Alright then.
Putting this on
/hold

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 21, 2019
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Dec 12, 2019

@LorbusChris: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/step-registry-shellcheck d0adb3f link /test step-registry-shellcheck

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants