Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-4.15] OCPBUGS-43605: Add SDN node subnet gateway IP to host-network address_set #2419

Open
wants to merge 1 commit into
base: release-4.15
Choose a base branch
from

Conversation

pliurh
Copy link
Contributor

@pliurh pliurh commented Jan 20, 2025

During live SDN migration, host-to-pod traffic originating from SDN nodes will use the first IP address of the hybrid overlay node subnet. These IPs are being added to ensure proper functionality of host network policies.

This manual backport resolved the conflict that the methodDeleteAddresses of AddressSet doesn't exist in 4.15, by replacing it with DeleteIPs.

@pliurh pliurh requested a review from trozet as a code owner January 20, 2025 02:39
@openshift-ci openshift-ci bot requested a review from jcaamano January 20, 2025 02:40
Copy link
Contributor

openshift-ci bot commented Jan 20, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: pliurh
Once this PR has been reviewed and has the lgtm label, please assign trozet for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@pliurh pliurh changed the title Add SDN node subnet gateway IP to host-network address_set [release-4.15] OCPBUGS-43605: Add SDN node subnet gateway IP to host-network address_set Jan 20, 2025
@openshift-ci-robot openshift-ci-robot added jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels Jan 20, 2025
@openshift-ci-robot
Copy link
Contributor

@pliurh: This pull request references Jira Issue OCPBUGS-43605, which is valid.

7 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.15.z) matches configured target version for branch (4.15.z)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)
  • release note type set to "Release Note Not Required"
  • dependent bug Jira Issue OCPBUGS-43344 is in the state Closed (Done-Errata), which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
  • dependent Jira Issue OCPBUGS-43344 targets the "4.16.z" version, which is one of the valid target versions: 4.16.0, 4.16.z
  • bug has dependents

Requesting review from QA contact:
/cc @zhaozhanqi

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

During live SDN migration, host-to-pod traffic originating from SDN nodes will use the first IP address of the hybrid overlay node subnet. These IPs are being added to ensure proper functionality of host network policies.

This manual backport resolved the conflict that the methodDeleteAddresses of AddressSet doesn't exist in 4.15, by replacing it with DeleteIPs.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested a review from zhaozhanqi January 20, 2025 02:41
During live SDN migration, host-to-pod traffic originating from
SDN nodes will use the first IP address of the hybrid overlay node
subnet. These IPs are being added to ensure proper functionality of
host network policies.

Signed-off-by: Peng Liu <[email protected]>
@pliurh
Copy link
Contributor Author

pliurh commented Jan 21, 2025

/retest-required

Copy link
Contributor

openshift-ci bot commented Jan 21, 2025

@pliurh: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/security b338432 link false /test security
ci/prow/e2e-metal-ipi-ovn-ipv6 b338432 link true /test e2e-metal-ipi-ovn-ipv6
ci/prow/e2e-azure-ovn-upgrade b338432 link true /test e2e-azure-ovn-upgrade
ci/prow/e2e-azure-ovn b338432 link false /test e2e-azure-ovn
ci/prow/e2e-aws-ovn-kubevirt b338432 link false /test e2e-aws-ovn-kubevirt
ci/prow/e2e-metal-ipi-ovn-dualstack b338432 link true /test e2e-metal-ipi-ovn-dualstack
ci/prow/e2e-aws-live-migration-sdn-ovn-rollback b338432 link false /test e2e-aws-live-migration-sdn-ovn-rollback
ci/prow/e2e-vsphere-ovn b338432 link false /test e2e-vsphere-ovn

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants