OCPBUGS-74237: Update MCN tests to better handle condition transitions through the "Unknown" state#30705
Conversation
|
Pipeline controller notification For optional jobs, comment This repository is configured in: automatic mode |
|
Skipping CI for Draft Pull Request. |
|
@isabella-janssen: This PR was included in a payload test run from openshift/machine-config-operator#5582
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/ed4ef340-f656-11f0-9d8c-addd25b6ef13-0 |
|
@isabella-janssen: This pull request references Jira Issue OCPBUGS-74237, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
Requesting review from QA contact: The bug has been updated to refer to the pull request using the external bug tracker. DetailsIn response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@isabella-janssen: This pull request references Jira Issue OCPBUGS-74237, which is valid. 3 validation(s) were run on this bug
Requesting review from QA contact: DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
Scheduling required tests: |
|
Risk analysis has seen new tests most likely introduced by this PR. New tests seen in this PR at sha: ec042d0
|
|
/retest-required |
|
/lgtm Seems sane to me, thanks for the fix-up! I guess we'll be double checking True state in some cases, but I suppose that's fine, let's see how the e2e behaves |
|
@djoshy: This PR was included in a payload test run from openshift/machine-config-operator#5582
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/ced38df0-f7a9-11f0-9d0e-2d5d72054b41-0 |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: djoshy, isabella-janssen The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/verified by payload rehearsal See payload rehearsal of test change here: openshift/machine-config-operator#5582 (comment) |
|
@isabella-janssen: This PR has been marked as verified by DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/retest-required |
|
@isabella-janssen: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
@isabella-janssen: Jira Issue Verification Checks: Jira Issue OCPBUGS-74237 Jira Issue OCPBUGS-74237 has been moved to the MODIFIED state and will move to the VERIFIED state when the change is available in an accepted nightly payload. 🕓 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
Fix included in accepted release 4.22.0-0.nightly-2026-01-24-213011 |
|
/cherrypick release-4.21 |
|
@isabella-janssen: new pull request created: #30729 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
This updates the MCO's
Should properly transition through MCN conditions on rebootless node updateMCN test to better handle cases where a test progresses so quickly that the "Unknown" state for a condition is missed.