Skip to content

OCPBUGS-74237: Update MCN tests to better handle condition transitions through the "Unknown" state#30705

Merged
openshift-merge-bot[bot] merged 1 commit intoopenshift:mainfrom
isabella-janssen:mcn-transtion-stabilization
Jan 22, 2026
Merged

OCPBUGS-74237: Update MCN tests to better handle condition transitions through the "Unknown" state#30705
openshift-merge-bot[bot] merged 1 commit intoopenshift:mainfrom
isabella-janssen:mcn-transtion-stabilization

Conversation

@isabella-janssen
Copy link
Member

@isabella-janssen isabella-janssen commented Jan 20, 2026

This updates the MCO's Should properly transition through MCN conditions on rebootless node update MCN test to better handle cases where a test progresses so quickly that the "Unknown" state for a condition is missed.

@openshift-ci-robot
Copy link

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: automatic mode

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 20, 2026

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci openshift-ci bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jan 20, 2026
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 20, 2026

@isabella-janssen: This PR was included in a payload test run from openshift/machine-config-operator#5582
trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-master-nightly-4.22-e2e-aws-ovn-serial-1of2

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/ed4ef340-f656-11f0-9d8c-addd25b6ef13-0

@isabella-janssen isabella-janssen changed the title (WIP) OCPBUGS-74237: Update MCN tests to better handle condition transitions through the "Unknown" state Jan 21, 2026
@openshift-ci-robot openshift-ci-robot added jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels Jan 21, 2026
@isabella-janssen isabella-janssen marked this pull request as ready for review January 21, 2026 19:04
@openshift-ci-robot
Copy link

@isabella-janssen: This pull request references Jira Issue OCPBUGS-74237, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.22.0) matches configured target version for branch (4.22.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @sergiordlr

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested a review from sergiordlr January 21, 2026 19:04
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 21, 2026
@openshift-ci openshift-ci bot requested review from djoshy and umohnani8 January 21, 2026 19:05
@openshift-ci-robot
Copy link

@isabella-janssen: This pull request references Jira Issue OCPBUGS-74237, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.22.0) matches configured target version for branch (4.22.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @sergiordlr

Details

In response to this:

This updates the MCO's Should properly transition through MCN conditions on rebootless node update MCN test to better handle cases where a test progresses so quickly that the "Unknown" state for a condition is missed.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link

Scheduling required tests:
/test e2e-aws-csi
/test e2e-aws-ovn-fips
/test e2e-aws-ovn-microshift
/test e2e-aws-ovn-microshift-serial
/test e2e-aws-ovn-serial-1of2
/test e2e-aws-ovn-serial-2of2
/test e2e-gcp-csi
/test e2e-gcp-ovn
/test e2e-gcp-ovn-upgrade
/test e2e-metal-ipi-ovn-ipv6
/test e2e-vsphere-ovn
/test e2e-vsphere-ovn-upi

@openshift-trt
Copy link

openshift-trt bot commented Jan 22, 2026

Risk analysis has seen new tests most likely introduced by this PR.
Please ensure that new tests meet guidelines for naming and stability.

New tests seen in this PR at sha: ec042d0

  • "[Monitor:crd-version-checker][Jira:"kube-apiserver"] monitor test crd-version-checker cleanup" [Total: 11, Pass: 11, Fail: 0, Flake: 0]
  • "[Monitor:crd-version-checker][Jira:"kube-apiserver"] monitor test crd-version-checker collection" [Total: 11, Pass: 11, Fail: 0, Flake: 0]
  • "[Monitor:crd-version-checker][Jira:"kube-apiserver"] monitor test crd-version-checker interval construction" [Total: 11, Pass: 11, Fail: 0, Flake: 0]
  • "[Monitor:crd-version-checker][Jira:"kube-apiserver"] monitor test crd-version-checker preparation" [Total: 11, Pass: 11, Fail: 0, Flake: 0]
  • "[Monitor:crd-version-checker][Jira:"kube-apiserver"] monitor test crd-version-checker setup" [Total: 11, Pass: 11, Fail: 0, Flake: 0]
  • "[Monitor:crd-version-checker][Jira:"kube-apiserver"] monitor test crd-version-checker test evaluation" [Total: 11, Pass: 11, Fail: 0, Flake: 0]
  • "[Monitor:crd-version-checker][Jira:"kube-apiserver"] monitor test crd-version-checker writing to storage" [Total: 11, Pass: 11, Fail: 0, Flake: 0]
  • "[Monitor:crd-version-checker][sig-api-machinery] CRDs with new API versions should not change storage version immediately" [Total: 11, Pass: 11, Fail: 0, Flake: 0]

@isabella-janssen
Copy link
Member Author

/retest-required

@djoshy
Copy link
Contributor

djoshy commented Jan 22, 2026

/lgtm

Seems sane to me, thanks for the fix-up! I guess we'll be double checking True state in some cases, but I suppose that's fine, let's see how the e2e behaves

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 22, 2026

@djoshy: This PR was included in a payload test run from openshift/machine-config-operator#5582
trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-master-nightly-4.22-e2e-aws-ovn-serial-1of2

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/ced38df0-f7a9-11f0-9d0e-2d5d72054b41-0

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 22, 2026
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 22, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: djoshy, isabella-janssen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@isabella-janssen
Copy link
Member Author

/verified by payload rehearsal

See payload rehearsal of test change here: openshift/machine-config-operator#5582 (comment)

@openshift-ci-robot openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Jan 22, 2026
@openshift-ci-robot
Copy link

@isabella-janssen: This PR has been marked as verified by payload rehearsal.

Details

In response to this:

/verified by payload rehearsal

See payload rehearsal of test change here: openshift/machine-config-operator#5582 (comment)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@isabella-janssen
Copy link
Member Author

/retest-required

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 22, 2026

@isabella-janssen: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 06e7030 into openshift:main Jan 22, 2026
20 checks passed
@openshift-ci-robot
Copy link

@isabella-janssen: Jira Issue Verification Checks: Jira Issue OCPBUGS-74237
✔️ This pull request was pre-merge verified.
✔️ All associated pull requests have merged.
✔️ All associated, merged pull requests were pre-merge verified.

Jira Issue OCPBUGS-74237 has been moved to the MODIFIED state and will move to the VERIFIED state when the change is available in an accepted nightly payload. 🕓

Details

In response to this:

This updates the MCO's Should properly transition through MCN conditions on rebootless node update MCN test to better handle cases where a test progresses so quickly that the "Unknown" state for a condition is missed.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@isabella-janssen isabella-janssen deleted the mcn-transtion-stabilization branch January 23, 2026 15:59
@openshift-merge-robot
Copy link
Contributor

Fix included in accepted release 4.22.0-0.nightly-2026-01-24-213011

@isabella-janssen
Copy link
Member Author

/cherrypick release-4.21

@openshift-cherrypick-robot

@isabella-janssen: new pull request created: #30729

Details

In response to this:

/cherrypick release-4.21

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. verified Signifies that the PR passed pre-merge verification criteria

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants