-
Notifications
You must be signed in to change notification settings - Fork 4.8k
OCPEDGE-2304: adjust olm test to pass on a degraded run #30664
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
OCPEDGE-2304: adjust olm test to pass on a degraded run #30664
Conversation
Signed-off-by: nhamza <[email protected]>
|
@Neilhamza: This pull request references OCPEDGE-2304 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
Pipeline controller notification For optional jobs, comment This repository is configured in: automatic mode |
|
I think this fix is clean and reasonable. |
|
Scheduling required tests: |
|
@Neilhamza: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jaypoulz, Neilhamza, xueqzhan The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/test e2e-metal-ovn-two-node-fencing-degraded-techpreview |
|
@Neilhamza: The specified target(s) for The following commands are available to trigger optional jobs: Use DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/payload-job periodic-ci-openshift-release-master-nightly-4.21-e2e-metal-ovn-two-node-fencing-degraded-techpreview |
|
/payload-job periodic-ci-openshift-release-master-nightly-4.22-e2e-metal-ovn-two-node-fencing-degraded-techpreview |
|
@Neilhamza: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/71dd3a60-eccd-11f0-85ad-5b932048545d-0 |
|
@Neilhamza: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/76430580-eccd-11f0-9b66-dcef7c811f13-0 |
while working on Two Node Fencing in a degraded mode, i ran e2e tests and this OLM test failed:
[sig-arch] ocp payload should be based on existing source OLM version should contain the source commit id [Suite:openshift/conformance/parallel]
the lane that runs TNF in a degraded mode can be found in the config:
https://github.com/openshift/release/blob/master/ci-operator/config/openshift/release/openshift-release-master__nightly-4.22.yaml#L587
an example run in which this test failed: (the other failed tests in this run has been handled already - testing locally i receive same timeout error however applying this change resulted in a succeed run)
https://prow.ci.openshift.org/view/gs/test-platform-results/pr-logs/pull/openshift_release/72974/rehearse-72974-periodic-ci-openshift-release-master-nightly-4.22-e2e-metal-ovn-two-node-fencing-degraded-techpreview/2005532130192396288
this small fix does a "trick" in which we target a running pod rather than a "random" pod
this fix does not apply any additional logic to the existing structure