NE-2376: Remove restriction of unmanaged x-k8s.io #30658
Conversation
|
Pipeline controller notification For optional jobs, comment This repository is configured in: automatic mode |
openshift-ci-robot
added
the
jira/valid-reference
|
@rikatz: This pull request references NE-2376 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: rikatz The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
/hold |
openshift-ci
bot
added
the
do-not-merge/hold
|
/test okd-scos-images |
|
/hold cancel |
openshift-ci
bot
removed
the
do-not-merge/hold
| g.It("and ensure CRD of experimental group is not installed", func() { | ||
| g.By("Ensure no CRD of experimental group is installed") | ||
| crdList, err := oc.AdminApiextensionsClient().ApiextensionsV1().CustomResourceDefinitions().List(context.Background(), metav1.ListOptions{}) | ||
| o.Expect(err).NotTo(o.HaveOccurred()) | ||
| for _, crd := range crdList.Items { | ||
| if crd.Spec.Group == "gateway.networking.x-k8s.io" { | ||
| e2e.Failf("Found unexpected CRD named: %v", crd.Name) | ||
| } | ||
| } | ||
| }) |
There was a problem hiding this comment.
Sorry - I might of missed something, but should we leave this? Shouldn't our default position be that experimental groups not be installed, so it's still fair to test for this?
There was a problem hiding this comment.
you ar eright, I will revert the removal of this test
Previously, cluster-ingress-operator would manage and block any
updates to CRDs that were from group gateway.networking.x-k8s.io.
After some analysis we identified that OSSM/Istio does filter these
resources in case it does not have a flag to enable alpha APIs, which means
it is safe to allow users to deploy these CRDs.
This way, this change removes any restriction on x-k8s.io group,
and removes any further reconciliation from CIO on x-k8s.io group.
Signed-off-by: Ricardo Pchevuzinske Katz <[email protected]>
|
Scheduling required tests: |
|
@rikatz: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
3 participants
Previously, cluster-ingress-operator would manage and block any
updates to CRDs that were from group gateway.networking.x-k8s.io.
After some analysis we identified that OSSM/Istio does filter these
resources in case it does not have a flag to enable alpha APIs, which means
it is safe to allow users to deploy these CRDs.
This way, this change removes any restriction on x-k8s.io group,
and removes any further reconciliation from CIO on x-k8s.io group.