Skip to content

Conversation

@ngopalak-redhat
Copy link
Contributor

@ngopalak-redhat ngopalak-redhat commented Jan 5, 2026

This PR introduces a new test suite specifically for node component testing, dubbed "Long Running Tests."

Following discussions with the MCO team on Slack, we agreed to separate specific disruptive node tests from the main MCO disruptive test suite.

Why not the Serial Suite? These tests cannot be part of the existing serial suite because they require multiple node reboots (exceeding the 3-restart limit) and have a significant runtime duration.

Goal is to establish a dedicated suite for tests that are disruptive and time-consuming but critical for release verification of the node component configuration (Kubelet).

Implementation Details

Adds the framework for long-running tests. Currently includes one test case: Changing the Kubelet Log Level.

  • The test applies a Kubelet config change.
  • It explicitly waits for the node reboot cycle to complete.

Configs are applied to a single node rather than all three. This reduces the blast radius and significantly speeds up execution. The suite includes logic to revert changes and clean up the node state post-execution.

Future Work / Roadmap

  • Post-merge, I will add tests for system-compressible and auto-node-sizing.

  • I will work with the MCO team to configure this as a Periodic Job (similar to the MCO disruptive tests). These tests will not run on every PR but will be a Release Blocking requirement.

Sample run: https://gist.github.com/ngopalak-redhat/0c63bddf63a0a49c46c9dd2a13fad465

@openshift-ci-robot
Copy link

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: automatic mode

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jan 5, 2026
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 5, 2026

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 5, 2026

@ngopalak-redhat: This pull request references OCPNODE-3203 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 5, 2026
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 5, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ngopalak-redhat
Once this PR has been reviewed and has the lgtm label, please assign neisw for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 5, 2026

@ngopalak-redhat: This pull request references OCPNODE-3203 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set.

Details

In response to this:

This PR introduces a new test suite specifically for node component testing, dubbed "Long Running Tests."

Following discussions with the MCO team on Slack, we agreed to separate specific disruptive node tests from the main MCO disruptive test suite.

Why not the Serial Suite? These tests cannot be part of the existing serial suite because they require multiple node reboots (exceeding the 3-restart limit) and have a significant runtime duration.

Goal is to establish a dedicated suite for tests that are disruptive and time-consuming but critical for release verification of the node component configuration (Kubelet).

Implementation Details

Adds the framework for long-running tests. Currently includes one test case: Changing the Kubelet Log Level.

  • The test applies a Kubelet config change.
  • It explicitly waits for the node reboot cycle to complete.

Configs are applied to a single node rather than all three. This reduces the blast radius and significantly speeds up execution. The suite includes logic to revert changes and clean up the node state post-execution.

Future Work / Roadmap

  • Post-merge, I will add tests for system-compressible and auto-node-sizing.

  • I will work with the MCO team to configure this as a Periodic Job (similar to the MCO disruptive tests). These tests will not run on every PR but will be a Release Blocking requirement.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@ngopalak-redhat
Copy link
Contributor Author

/test all

@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 5, 2026

@ngopalak-redhat: This pull request references OCPNODE-3203 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set.

Details

In response to this:

This PR introduces a new test suite specifically for node component testing, dubbed "Long Running Tests."

Following discussions with the MCO team on Slack, we agreed to separate specific disruptive node tests from the main MCO disruptive test suite.

Why not the Serial Suite? These tests cannot be part of the existing serial suite because they require multiple node reboots (exceeding the 3-restart limit) and have a significant runtime duration.

Goal is to establish a dedicated suite for tests that are disruptive and time-consuming but critical for release verification of the node component configuration (Kubelet).

Implementation Details

Adds the framework for long-running tests. Currently includes one test case: Changing the Kubelet Log Level.

  • The test applies a Kubelet config change.
  • It explicitly waits for the node reboot cycle to complete.

Configs are applied to a single node rather than all three. This reduces the blast radius and significantly speeds up execution. The suite includes logic to revert changes and clean up the node state post-execution.

Future Work / Roadmap

  • Post-merge, I will add tests for system-compressible and auto-node-sizing.

  • I will work with the MCO team to configure this as a Periodic Job (similar to the MCO disruptive tests). These tests will not run on every PR but will be a Release Blocking requirement.

Sample run: https://gist.github.com/ngopalak-redhat/0c63bddf63a0a49c46c9dd2a13fad465

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@ngopalak-redhat ngopalak-redhat marked this pull request as ready for review January 5, 2026 09:11
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 5, 2026
@ngopalak-redhat
Copy link
Contributor Author

/test all

@openshift-ci-robot
Copy link

Scheduling required tests:
/test e2e-aws-csi
/test e2e-aws-ovn-fips
/test e2e-aws-ovn-microshift
/test e2e-aws-ovn-microshift-serial
/test e2e-aws-ovn-serial-1of2
/test e2e-aws-ovn-serial-2of2
/test e2e-gcp-csi
/test e2e-gcp-ovn
/test e2e-gcp-ovn-upgrade
/test e2e-metal-ipi-ovn-ipv6
/test e2e-vsphere-ovn
/test e2e-vsphere-ovn-upi

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 9, 2026

@ngopalak-redhat: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants