OCPBUGS-66065: remove duplicated events before processing lease intervals #30639

jianlinliu · 2025-12-23T11:21:14Z

No description provided.

openshift-ci-robot · 2025-12-23T11:21:17Z

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: automatic mode

openshift-ci-robot · 2025-12-23T11:24:12Z

@jianlinliu: This pull request references Jira Issue OCPBUGS-66065, which is invalid:

expected the bug to target the "4.22.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

jianlinliu · 2025-12-23T11:27:23Z

/jira refresh

openshift-ci-robot · 2025-12-23T11:27:31Z

@jianlinliu: This pull request references Jira Issue OCPBUGS-66065, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target version (4.22.0) matches configured target version for branch (4.22.0)
bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

jianlinliu · 2025-12-24T02:07:30Z

/test okd-scos-images

neisw · 2026-01-05T16:45:38Z

/pipeline required

openshift-ci-robot · 2026-01-05T16:45:41Z

Scheduling required tests:
/test e2e-aws-csi
/test e2e-aws-ovn-fips
/test e2e-aws-ovn-microshift
/test e2e-aws-ovn-microshift-serial
/test e2e-aws-ovn-serial-1of2
/test e2e-aws-ovn-serial-2of2
/test e2e-gcp-csi
/test e2e-gcp-ovn
/test e2e-gcp-ovn-upgrade
/test e2e-metal-ipi-ovn-ipv6
/test e2e-vsphere-ovn
/test e2e-vsphere-ovn-upi

jianlinliu · 2026-01-06T06:05:52Z

/payload-aggregate periodic-ci-openshift-release-master-nightly-4.21-e2e-rosa-sts-ovn 5

openshift-ci · 2026-01-06T06:05:56Z

@jianlinliu: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

periodic-ci-openshift-release-master-nightly-4.21-e2e-rosa-sts-ovn

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/c280c040-eac5-11f0-90a8-cb5cd2cd29b7-0

jianlinliu · 2026-01-06T07:48:38Z

okd-scos-images failure is being fixed by coreos/rhel-coreos-config#134

jianlinliu · 2026-01-06T07:49:18Z

/test okd-scos-images

jianlinliu · 2026-01-07T09:28:54Z

@jianlinliu: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

periodic-ci-openshift-release-master-nightly-4.21-e2e-rosa-sts-ovn

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/c280c040-eac5-11f0-90a8-cb5cd2cd29b7-0

seem like we can not run ROSA payload testing.

jianlinliu · 2026-01-07T09:29:03Z

/test okd-scos-images

jianlinliu · 2026-01-07T12:36:15Z

@dgoodwin @neisw can you help review this PR ? And shall we override okd-scos-images ?

dgoodwin · 2026-01-07T12:41:24Z

/override ci/prow/okd-scos-images

openshift-ci · 2026-01-07T12:41:34Z

@dgoodwin: Overrode contexts on behalf of dgoodwin: ci/prow/okd-scos-images

Details

In response to this:

/override ci/prow/okd-scos-images

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

dgoodwin · 2026-01-07T12:43:17Z

pkg/monitortests/testframework/operatorloganalyzer/operator_lease_check.go

 	})
 	sort.Sort(byLeaseAcquisition(leaseIntervals))

+	// Deduplicate intervals before processing


I would just add a comment on why this happens if possible, or maybe a link to the Jira. Someone who sees this will be confused why there are duped.

dgoodwin · 2026-01-07T13:00:17Z

/lgtm

openshift-ci · 2026-01-07T13:04:50Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dgoodwin, jianlinliu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [dgoodwin]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

jianlinliu · 2026-01-07T15:54:04Z

@dgoodwin do you mind to override okd-scos-images again ?

dgoodwin · 2026-01-07T18:37:07Z

/override ci/prow/okd-scos-images

openshift-ci-robot · 2026-01-07T18:37:26Z

Scheduling required tests:
/test e2e-aws-csi
/test e2e-aws-ovn-fips
/test e2e-aws-ovn-microshift
/test e2e-aws-ovn-microshift-serial
/test e2e-aws-ovn-serial-1of2
/test e2e-aws-ovn-serial-2of2
/test e2e-gcp-csi
/test e2e-gcp-ovn
/test e2e-gcp-ovn-upgrade
/test e2e-metal-ipi-ovn-ipv6
/test e2e-vsphere-ovn
/test e2e-vsphere-ovn-upi

openshift-ci · 2026-01-07T18:37:27Z

@dgoodwin: Overrode contexts on behalf of dgoodwin: ci/prow/okd-scos-images

Details

In response to this:

/override ci/prow/okd-scos-images

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

jianlinliu · 2026-01-08T01:03:21Z

/verified by jialiu

openshift-ci-robot · 2026-01-08T01:03:32Z

@jianlinliu: This PR has been marked as verified by jialiu.

Details

In response to this:

/verified by jialiu

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot · 2026-01-08T01:32:29Z

/retest-required

Remaining retests: 0 against base HEAD 6368022 and 2 for PR HEAD f057a21 in total

jianlinliu · 2026-01-08T02:01:03Z

/override ci/prow/okd-scos-images

openshift-ci · 2026-01-08T02:01:25Z

@jianlinliu: jianlinliu unauthorized: /override is restricted to Repo administrators, approvers in top level OWNERS file, and the following github teams:openshift: openshift-release-oversight openshift-staff-engineers openshift-sustaining-engineers.

Details

In response to this:

/override ci/prow/okd-scos-images

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

sdodson · 2026-01-08T02:40:41Z

/override ci/prow/okd-scos-images

openshift-ci · 2026-01-08T02:40:47Z

@sdodson: Overrode contexts on behalf of sdodson: ci/prow/okd-scos-images

Details

In response to this:

/override ci/prow/okd-scos-images

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

openshift-ci · 2026-01-08T02:40:49Z

@jianlinliu: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

openshift-ci-robot · 2026-01-08T02:42:41Z

@jianlinliu: Jira Issue Verification Checks: Jira Issue OCPBUGS-66065
✔️ This pull request was pre-merge verified.
✔️ All associated pull requests have merged.
✔️ All associated, merged pull requests were pre-merge verified.

Jira Issue OCPBUGS-66065 has been moved to the MODIFIED state and will move to the VERIFIED state when the change is available in an accepted nightly payload. 🕓

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

jianlinliu · 2026-01-08T03:18:07Z

/cherry-pick release-4.21

openshift-cherrypick-robot · 2026-01-08T03:18:54Z

@jianlinliu: new pull request created: #30662

Details

In response to this:

/cherry-pick release-4.21

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

openshift-ci bot requested review from p0lyn0mial and sjenning December 23, 2025 11:22

jianlinliu changed the title ~~remove duplicated events before processing lease intervals~~ OCPBUGS-66065: remove duplicated events before processing lease intervals Dec 23, 2025

openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Dec 23, 2025

openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Dec 23, 2025

dgoodwin reviewed Jan 7, 2026

View reviewed changes

remove duplidated events before processing lease intervals

f057a21

jianlinliu force-pushed the lease-checker-fix-1 branch from d3458d1 to f057a21 Compare January 7, 2026 12:47

openshift-ci bot assigned dgoodwin Jan 7, 2026

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 7, 2026

openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 7, 2026

openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Jan 8, 2026

openshift-merge-bot bot merged commit 0194826 into openshift:main Jan 8, 2026
20 checks passed

openshift-cherrypick-robot mentioned this pull request Jan 8, 2026

[release-4.21] OCPBUGS-71242: remove duplicated events before processing lease intervals #30662

Open

OCPBUGS-66065: remove duplicated events before processing lease intervals #30639

OCPBUGS-66065: remove duplicated events before processing lease intervals #30639

Uh oh!

Conversation

jianlinliu commented Dec 23, 2025

Uh oh!

openshift-ci-robot commented Dec 23, 2025

Uh oh!

openshift-ci-robot commented Dec 23, 2025

Uh oh!

jianlinliu commented Dec 23, 2025

Uh oh!

openshift-ci-robot commented Dec 23, 2025

Uh oh!

jianlinliu commented Dec 24, 2025

Uh oh!

neisw commented Jan 5, 2026

Uh oh!

openshift-ci-robot commented Jan 5, 2026

Uh oh!

jianlinliu commented Jan 6, 2026

Uh oh!

openshift-ci bot commented Jan 6, 2026

Uh oh!

jianlinliu commented Jan 6, 2026

Uh oh!

jianlinliu commented Jan 6, 2026

Uh oh!

jianlinliu commented Jan 7, 2026

Uh oh!

jianlinliu commented Jan 7, 2026

Uh oh!

jianlinliu commented Jan 7, 2026

Uh oh!

dgoodwin commented Jan 7, 2026

Uh oh!

openshift-ci bot commented Jan 7, 2026

Uh oh!

dgoodwin Jan 7, 2026

Choose a reason for hiding this comment

Uh oh!

jianlinliu Jan 7, 2026

Choose a reason for hiding this comment

Uh oh!

dgoodwin commented Jan 7, 2026

Uh oh!

openshift-ci bot commented Jan 7, 2026

Uh oh!

jianlinliu commented Jan 7, 2026

Uh oh!

dgoodwin commented Jan 7, 2026

Uh oh!

openshift-ci-robot commented Jan 7, 2026

Uh oh!

openshift-ci bot commented Jan 7, 2026

Uh oh!

jianlinliu commented Jan 8, 2026

Uh oh!

openshift-ci-robot commented Jan 8, 2026

Uh oh!

openshift-ci-robot commented Jan 8, 2026

Uh oh!

jianlinliu commented Jan 8, 2026

Uh oh!

openshift-ci bot commented Jan 8, 2026

Uh oh!

sdodson commented Jan 8, 2026

Uh oh!

openshift-ci bot commented Jan 8, 2026

Uh oh!

openshift-ci bot commented Jan 8, 2026

Uh oh!

Uh oh!

openshift-ci-robot commented Jan 8, 2026

Uh oh!

jianlinliu commented Jan 8, 2026

Uh oh!

openshift-cherrypick-robot commented Jan 8, 2026

Uh oh!

Reviewers