-
Notifications
You must be signed in to change notification settings - Fork 4.8k
CO must go Progressing during a minor-level upgrade #30626
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Pipeline controller notification For optional jobs, comment This repository is configured in: automatic mode |
|
/payload-job periodic-ci-openshift-release-master-ci-4.21-upgrade-from-stable-4.20-e2e-gcp-ovn-rt-upgrade |
|
@hongkailiu: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/80784cc0-dc99-11f0-929c-f4f25ee978e7-0 |
|
Scheduling required tests: |
|
/test e2e-gcp-ovn-upgrade |
|
Minor upgrade is not skipped. Edit |
|
/retest-required |
pkg/monitortests/clusterversionoperator/legacycvomonitortests/operators_test.go
Outdated
Show resolved
Hide resolved
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: hongkailiu The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Follow up [1]: in CI tests there are many patch-level upgrade we made between the same payload manifests with a renamed version. In those cases, it is OK that CO does not report Progressing. Ideally, CI should enforce Progressing only when there are changes. Before there is a practical way to achieve it, we focus on minor upgrades only. [1]. https://issues.redhat.com/browse/OCPSTRAT-2484?focusedId=28681908&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-28681908
…operators_test.go Co-authored-by: Ondrej Pokorny <[email protected]>
3955dcb to
745cedb
Compare
|
Scheduling required tests: |
|
@hongkailiu: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Follow up [1]: in CI tests there are many patch-level upgrade we made between the same payload manifests with a renamed version.
In those cases, it is OK that CO does not report Progressing. Ideally, CI should enforce Progressing only when there are changes. Before there is a practical way to achieve it, we focus on minor upgrades only.
[1]. https://issues.redhat.com/browse/OCPSTRAT-2484?focusedId=28681908&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-28681908