This repository was archived by the owner on Aug 29, 2018. It is now read-only.
avahi-cname-manager: Fix CNAME regex to match OpenShift constraints #6228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bug 1258562 Bugzilla link https://bugzilla.redhat.com/show_bug.cgi?id=1258562 The old CNAME validity regex is far more restrictive than OpenShift, which allows alphanumeric domains while the regex allowed only alphabetical.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug 1258562
Bugzilla link https://bugzilla.redhat.com/show_bug.cgi?id=1258562
The old CNAME validity regex is far more restrictive than OpenShift, which
allows alphanumeric domains while the regex allowed only alphabetical.