[release-4.19] OCPBUGS-86968: catalogd: clean up orphaned temp dirs in catalog storage#747
Conversation
…log storage
LocalDirV1.Store creates a temp dir (.{catalog}-{random}) and renames it
into place atomically. If the process is interrupted before the deferred
RemoveAll runs, the temp dir persists. Each restart adds another, eventually
filling the disk.
Primary fix: remove any matching temp dirs at the start of Store before
creating a new one. Since Store holds the write mutex, any dirs found are
guaranteed to be from a previous run.
Defense-in-depth: add /var/cache/catalogs to GarbageCollector's list of
scanned paths (CachePath string -> CachePaths []string), so orphaned temp
dirs are also removed by the periodic GC cycle.
Backport of OCPBUGS-76453 to release-4.21.
Signed-off-by: Rashmi Gottipati <rgottipa@redhat.com>
|
@openshift-cherrypick-robot: An error was encountered cloning bug for cherrypick for bug OCPBUGS-86968 on the Jira server at https://redhat.atlassian.net. No known errors were detected, please see the full error message for details. Full error message.
request failed. Please analyze the request body for more details. Status code: 400: {"errorMessages":[],"errors":{"customfield_10001":"Team id '{isVerified=BooleanValue[value=false], avatarUrl=StringValue[value=], name=StringValue[value=pod-puce-vole], isVisible=BooleanValue[value=true], id=StringValue[value=11b37e6e-a5ca-4afc-816b-91d853d3fd28], title=StringValue[value=pod-puce-vole], isShared=BooleanValue[value=true]}' is not valid."}}
Please contact an administrator to resolve this issue, then request a bug refresh with DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository: openshift/coderabbit/.coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: openshift-cherrypick-robot The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
@openshift-cherrypick-robot: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
cc @tmshort |
|
/jira refresh |
openshift-ci-robot
added
jira/severity-moderate
|
@rashmigottipati: This pull request references Jira Issue OCPBUGS-86968, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
Need to close this in favor of: #748 |
|
/hold |
openshift-ci
Bot
added
the
do-not-merge/hold
|
Fix included in release 4.20.0-0.nightly-2026-06-05-230804 |
5 participants
This is an automated cherry-pick of #744
/assign rashmigottipati