-
Notifications
You must be signed in to change notification settings - Fork 1.8k
Add transmit hash policy to bond CNI (Tech Preview) #96525
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🤖 Fri Jul 25 11:50:38 - Prow CI generated the docs preview: |
Updated @mlguerrero12 thanks |
@@ -44,6 +44,10 @@ The following table describes the configuration parameters for the Bond CNI plug | |||
|`string` | |||
|Specifies the bonding policy. | |||
|
|||
|`xmitHashPolicy` | |||
|`string` | |||
|Specifies the transmit hash policy for load balancing across the aggregated interfaces in `balance-xor`, `802.3ad`, and `tlb` bonding modes. This parameter defaults to `layer2` and supports the following values: `layer2`, `layer2+3` and `layer3+4`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wouldn't mention the bonding modes. I would end on interfaces since we don't support all modes
@cgoncalves, please take a look |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small comment, otherwise LGTM
/lgtm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work! I only have a few nits.
New changes are detected. LGTM label has been removed. |
9ccad3d
to
df3bc7d
Compare
@kquinn1204: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
@amolnar-rh comments actioned so good to go . THanks |
/cherry-pick enterprise-4.20 |
/cherrypick enterprise-4.20 |
@amolnar-rh: new pull request created: #96698 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
@amolnar-rh: new pull request could not be created: failed to create pull request against openshift/openshift-docs#enterprise-4.20 from head openshift-cherrypick-robot:cherry-pick-96525-to-enterprise-4.20: status code 422 not one of [201], body: {"message":"Validation Failed","errors":[{"resource":"PullRequest","code":"custom","message":"A pull request already exists for openshift-cherrypick-robot:cherry-pick-96525-to-enterprise-4.20."}],"documentation_url":"https://docs.github.com/rest/pulls/pulls#create-a-pull-request","status":"422"} In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
[TELCODOCS-2278]: Add transmit hash policy to bond CNI (Tech Preview)
Version(s): 4.20
Issue:https://issues.redhat.com/browse/TELCODOCS-2278
Link to docs preview:https://96525--ocpdocs-pr.netlify.app/openshift-enterprise/latest/networking/multiple_networks/secondary_networks/creating-secondary-nwt-other-cni.html#nw-multus-bond-cni-object_configuring-additional-network-cni
QE review: No QE involved confirmed with Carlos and this set to TP.
Additional information: