Skip to content

Add transmit hash policy to bond CNI (Tech Preview) #96525

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 25, 2025

Conversation

kquinn1204
Copy link
Contributor

@kquinn1204 kquinn1204 commented Jul 23, 2025

[TELCODOCS-2278]: Add transmit hash policy to bond CNI (Tech Preview)

Version(s): 4.20

Issue:https://issues.redhat.com/browse/TELCODOCS-2278

Link to docs preview:https://96525--ocpdocs-pr.netlify.app/openshift-enterprise/latest/networking/multiple_networks/secondary_networks/creating-secondary-nwt-other-cni.html#nw-multus-bond-cni-object_configuring-additional-network-cni

QE review: No QE involved confirmed with Carlos and this set to TP.

  • QE has approved this change.

Additional information:

@openshift-ci openshift-ci bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jul 23, 2025
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Jul 23, 2025

@openshift-ci openshift-ci bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 23, 2025
@kquinn1204
Copy link
Contributor Author

Updated @mlguerrero12 thanks

@@ -44,6 +44,10 @@ The following table describes the configuration parameters for the Bond CNI plug
|`string`
|Specifies the bonding policy.

|`xmitHashPolicy`
|`string`
|Specifies the transmit hash policy for load balancing across the aggregated interfaces in `balance-xor`, `802.3ad`, and `tlb` bonding modes. This parameter defaults to `layer2` and supports the following values: `layer2`, `layer2+3` and `layer3+4`.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wouldn't mention the bonding modes. I would end on interfaces since we don't support all modes

@mlguerrero12
Copy link
Member

@cgoncalves, please take a look

Copy link
Contributor

@cgoncalves cgoncalves left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small comment, otherwise LGTM

@cgoncalves
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 25, 2025
Copy link
Contributor

@amolnar-rh amolnar-rh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! I only have a few nits.

@amolnar-rh amolnar-rh added this to the Planned for 4.20 GA milestone Jul 25, 2025
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Jul 25, 2025
Copy link

openshift-ci bot commented Jul 25, 2025

New changes are detected. LGTM label has been removed.

Copy link

openshift-ci bot commented Jul 25, 2025

@kquinn1204: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@kquinn1204
Copy link
Contributor Author

@amolnar-rh comments actioned so good to go . THanks

@amolnar-rh amolnar-rh merged commit fe6f58b into openshift:main Jul 25, 2025
2 checks passed
@amolnar-rh
Copy link
Contributor

/cherry-pick enterprise-4.20

@amolnar-rh
Copy link
Contributor

/cherrypick enterprise-4.20

@openshift-cherrypick-robot

@amolnar-rh: new pull request created: #96698

In response to this:

/cherry-pick enterprise-4.20

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot

@amolnar-rh: new pull request could not be created: failed to create pull request against openshift/openshift-docs#enterprise-4.20 from head openshift-cherrypick-robot:cherry-pick-96525-to-enterprise-4.20: status code 422 not one of [201], body: {"message":"Validation Failed","errors":[{"resource":"PullRequest","code":"custom","message":"A pull request already exists for openshift-cherrypick-robot:cherry-pick-96525-to-enterprise-4.20."}],"documentation_url":"https://docs.github.com/rest/pulls/pulls#create-a-pull-request","status":"422"}

In response to this:

/cherrypick enterprise-4.20

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
branch/enterprise-4.20 size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants