Skip to content

Conversation

jeana-redhat
Copy link
Contributor

@jeana-redhat jeana-redhat commented Jul 21, 2025

Version(s):
main

Issue:
N/A, from https://docs.google.com/document/d/1bjWS6qWyiuiYTYUAU6Hs5RG-Y6GGcAs06JrVbhEI2mg/edit?disco=AAABnaCa_ic&tab=t.vqt3znw847jf

Link to docs preview:

DPM review:

  • DPM has approved this change.

Additional information:
Noticed a few stale guidelines while i was looking for metadata examples.

@openshift-ci openshift-ci bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jul 21, 2025
@jeana-redhat
Copy link
Contributor Author

@kalexand-rh, PTAL 🙇

From our discussion in the new merge guidelines doc. Lmk if any other review is needed. If you approve, I can go delete the lines I commented out.

@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Jul 21, 2025

🤖 Mon Aug 18 16:34:51 - Prow CI generated the docs preview:

https://96408--ocpdocs-pr.netlify.app/

@kalexand-rh
Copy link
Contributor

@bergerhoffer, is there anything else you want to get into this round of updates?

Copy link
Contributor

@bergerhoffer bergerhoffer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay, this LGTM to me. Though I'd say maybe just remove some of the pieces that you've commented out, just to keep it cleaner.

But otherwise, we can always make additional updates in the future as needed

@jeana-redhat jeana-redhat force-pushed the migration-compatible-metadata-sample branch from 64dea94 to 4d5e8be Compare August 18, 2025 14:00
@jeana-redhat jeana-redhat added the merge-review-needed Signifies that the merge review team needs to review this PR label Aug 18, 2025
@jeana-redhat jeana-redhat force-pushed the migration-compatible-metadata-sample branch from 4d5e8be to 14b8010 Compare August 18, 2025 14:44
@jeana-redhat jeana-redhat force-pushed the migration-compatible-metadata-sample branch from 14b8010 to 45ba729 Compare August 18, 2025 16:15
@jeana-redhat jeana-redhat force-pushed the migration-compatible-metadata-sample branch from 45ba729 to cd14b29 Compare August 18, 2025 16:15
Copy link

openshift-ci bot commented Aug 18, 2025

@jeana-redhat: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@jeana-redhat jeana-redhat merged commit 218efe1 into openshift:main Aug 18, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge-review-needed Signifies that the merge review team needs to review this PR size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants