-
Notifications
You must be signed in to change notification settings - Fork 1.8k
Updates samples for migration, removes stale guidelines #96408
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updates samples for migration, removes stale guidelines #96408
Conversation
@kalexand-rh, PTAL 🙇 From our discussion in the new merge guidelines doc. Lmk if any other review is needed. If you approve, I can go delete the lines I commented out. |
🤖 Mon Aug 18 16:34:51 - Prow CI generated the docs preview: |
@bergerhoffer, is there anything else you want to get into this round of updates? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the delay, this LGTM to me. Though I'd say maybe just remove some of the pieces that you've commented out, just to keep it cleaner.
But otherwise, we can always make additional updates in the future as needed
64dea94
to
4d5e8be
Compare
4d5e8be
to
14b8010
Compare
14b8010
to
45ba729
Compare
45ba729
to
cd14b29
Compare
@jeana-redhat: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Version(s):
main
Issue:
N/A, from https://docs.google.com/document/d/1bjWS6qWyiuiYTYUAU6Hs5RG-Y6GGcAs06JrVbhEI2mg/edit?disco=AAABnaCa_ic&tab=t.vqt3znw847jf
Link to docs preview:
DPM review:
Additional information:
Noticed a few stale guidelines while i was looking for metadata examples.