-
Notifications
You must be signed in to change notification settings - Fork 1.8k
TELCODOCS-2171#Generalize Day2Ops Observability #96104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
/label peer-review-needed |
Prometheus scrapes the path `/metrics` by default, however you can define a custom path. | ||
It is up to the vendor of the application to expose this endpoint for scraping, with metrics that they deem relevant. | ||
Prometheus scrapes the `/metrics` path by default. However, you can define a custom path. | ||
The vendor of the application must decide whether to expose the endpoint for scraping, with metrics that they deem relevant. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not familiar with how this works, but could the vendor of the application just be the user?
Could you remove this line? Prometheus scrapes the /metrics endpoint by default, but you can define a custom path. Whatever metrics are scraped are determined by how the user application is configured? Just slightly confused by who the vendor of the application is or what that means
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rfisher001 Could you please take a look?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please squash commits to one. See https://docs.google.com/document/d/1fLMpK4bqthtFlCwA36yeo2cI-pExFpX76VMnSi_In6Q/edit?tab=t.0#heading=h.epes4xf06pzk in the OpensShift Manual.
Also, please indicate which versions of OpenShift this PR applies to.
A few minor comments. Otherwise, LGTM!
|
||
{odf-first}, which deploys a ceph cluster for block, file, and object storage, is also a suitable candidate for a Telco core cluster. | ||
For smaller clusters, you can use the Local Storage Operator for persistent storage for Prometheus. {odf-first}, which deploys a ceph cluster for block, file, and object storage, is suitable for larger clusters. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there any guidance on what constitutes a larger vs smaller clusters?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rfisher001 Could you please take a look?
b4f57a2
to
c19a55e
Compare
c19a55e
to
14927b7
Compare
@amolnar-rh: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Version(s):
Issue: https://issues.redhat.com/browse/TELCODOCS-2171
Link to docs preview: https://96104--ocpdocs-pr.netlify.app/openshift-enterprise/latest/edge_computing/day_2_core_cnf_clusters/observability/observability
QE review:
Additional information: