Skip to content

TELCODOCS-2171#Generalize Day2Ops Observability #96104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

amolnar-rh
Copy link
Contributor

@amolnar-rh amolnar-rh commented Jul 15, 2025

@openshift-ci openshift-ci bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jul 15, 2025
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Jul 15, 2025

@amolnar-rh
Copy link
Contributor Author

/label peer-review-needed

@openshift-ci openshift-ci bot added the peer-review-needed Signifies that the peer review team needs to review this PR label Jul 16, 2025
Prometheus scrapes the path `/metrics` by default, however you can define a custom path.
It is up to the vendor of the application to expose this endpoint for scraping, with metrics that they deem relevant.
Prometheus scrapes the `/metrics` path by default. However, you can define a custom path.
The vendor of the application must decide whether to expose the endpoint for scraping, with metrics that they deem relevant.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not familiar with how this works, but could the vendor of the application just be the user?

Could you remove this line? Prometheus scrapes the /metrics endpoint by default, but you can define a custom path. Whatever metrics are scraped are determined by how the user application is configured? Just slightly confused by who the vendor of the application is or what that means

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rfisher001 Could you please take a look?

@lpettyjo lpettyjo self-requested a review July 18, 2025 15:06
@lpettyjo lpettyjo added peer-review-in-progress Signifies that the peer review team is reviewing this PR and removed peer-review-needed Signifies that the peer review team needs to review this PR labels Jul 18, 2025
Copy link
Contributor

@lpettyjo lpettyjo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please squash commits to one. See https://docs.google.com/document/d/1fLMpK4bqthtFlCwA36yeo2cI-pExFpX76VMnSi_In6Q/edit?tab=t.0#heading=h.epes4xf06pzk in the OpensShift Manual.

Also, please indicate which versions of OpenShift this PR applies to.

A few minor comments. Otherwise, LGTM!


{odf-first}, which deploys a ceph cluster for block, file, and object storage, is also a suitable candidate for a Telco core cluster.
For smaller clusters, you can use the Local Storage Operator for persistent storage for Prometheus. {odf-first}, which deploys a ceph cluster for block, file, and object storage, is suitable for larger clusters.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there any guidance on what constitutes a larger vs smaller clusters?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rfisher001 Could you please take a look?

@lpettyjo lpettyjo added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-in-progress Signifies that the peer review team is reviewing this PR labels Jul 18, 2025
@amolnar-rh amolnar-rh force-pushed the TELCODOCS-2171-observability branch 3 times, most recently from b4f57a2 to c19a55e Compare July 21, 2025 10:52
@amolnar-rh amolnar-rh force-pushed the TELCODOCS-2171-observability branch from c19a55e to 14927b7 Compare July 22, 2025 13:16
Copy link

openshift-ci bot commented Jul 22, 2025

@amolnar-rh: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
peer-review-done Signifies that the peer review team has reviewed this PR size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants